linux-kernel - Re: [PATCH] selftests/bpf: Simplify the calculation of variables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAEf4BzaMuMq0fwd6DvSx3VuHpMMDhs8tC-LhQ6q3RY-4W0w0zg@mail.gmail.com>
Date:   Mon, 8 Feb 2021 21:20:54 -0800
From:   Andrii Nakryiko <andrii.nakryiko@...il.com>
To:     Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
Cc:     Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Jesper Dangaard Brouer <hawk@...nel.org>,
        john fastabend <john.fastabend@...il.com>,
        Shuah Khan <shuah@...nel.org>,
        Andrii Nakryiko <andrii@...nel.org>, Martin Lau <kafai@...com>,
        Song Liu <songliubraving@...com>, Yonghong Song <yhs@...com>,
        KP Singh <kpsingh@...nel.org>,
        Networking <netdev@...r.kernel.org>, bpf <bpf@...r.kernel.org>,
        "open list:KERNEL SELFTEST FRAMEWORK" 
        <linux-kselftest@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] selftests/bpf: Simplify the calculation of variables

On Thu, Feb 4, 2021 at 10:27 PM Jiapeng Chong
<jiapeng.chong@...ux.alibaba.com> wrote:
>
> Fix the following coccicheck warnings:
>
> ./tools/testing/selftests/bpf/xdpxceiver.c:954:28-30: WARNING !A || A &&
> B is equivalent to !A || B.
>
> ./tools/testing/selftests/bpf/xdpxceiver.c:932:28-30: WARNING !A || A &&
> B is equivalent to !A || B.
>
> ./tools/testing/selftests/bpf/xdpxceiver.c:909:28-30: WARNING !A || A &&
> B is equivalent to !A || B.
>
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
> ---

This doesn't apply cleanly onto bpf-next anymore. Please rebase and
re-submit. Make sure to include [PATCH bpf-next] prefix in your email
subject. Thanks!

>  tools/testing/selftests/bpf/xdpxceiver.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/tools/testing/selftests/bpf/xdpxceiver.c b/tools/testing/selftests/bpf/xdpxceiver.c
> index 1e722ee..98ad4a2 100644
> --- a/tools/testing/selftests/bpf/xdpxceiver.c
> +++ b/tools/testing/selftests/bpf/xdpxceiver.c
> @@ -906,7 +906,7 @@ static void *worker_testapp_validate(void *arg)
>                         ksft_print_msg("Destroying socket\n");
>         }
>
> -       if (!opt_bidi || (opt_bidi && bidi_pass)) {
> +       if (!opt_bidi || bidi_pass) {
>                 xsk_socket__delete(((struct ifobject *)arg)->xsk->xsk);
>                 (void)xsk_umem__delete(((struct ifobject *)arg)->umem->umem);
>         }
> @@ -929,7 +929,7 @@ static void testapp_validate(void)
>         pthread_mutex_lock(&sync_mutex);
>
>         /*Spawn RX thread */
> -       if (!opt_bidi || (opt_bidi && !bidi_pass)) {
> +       if (!opt_bidi || !bidi_pass) {
>                 if (pthread_create(&t0, &attr, worker_testapp_validate, (void *)ifdict[1]))
>                         exit_with_error(errno);
>         } else if (opt_bidi && bidi_pass) {
> @@ -951,7 +951,7 @@ static void testapp_validate(void)
>         pthread_mutex_unlock(&sync_mutex);
>
>         /*Spawn TX thread */
> -       if (!opt_bidi || (opt_bidi && !bidi_pass)) {
> +       if (!opt_bidi || !bidi_pass) {
>                 if (pthread_create(&t1, &attr, worker_testapp_validate, (void *)ifdict[0]))
>                         exit_with_error(errno);
>         } else if (opt_bidi && bidi_pass) {
> --
> 1.8.3.1
>