linux-kernel - Re: [PATCH] checkpatch: do not apply "initialise globals to 0" check to BPF progs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9022d7bcb1743c20dbeedc729c12d93877cb70fe.camel@perches.com>
Date:   Mon, 08 Feb 2021 22:31:19 -0800
From:   Joe Perches <joe@...ches.com>
To:     Song Liu <songliubraving@...com>, linux-kernel@...r.kernel.org
Cc:     bpf@...r.kernel.org, Andy Whitcroft <apw@...onical.com>
Subject: Re: [PATCH] checkpatch: do not apply "initialise globals to 0"
 check to BPF progs

On Mon, 2021-02-08 at 15:40 -0800, Song Liu wrote:
> BPF programs explicitly initialise global variables to 0 to make sure
> clang (v10 or older) do not put the variables in the common section.
> Skip "initialise globals to 0" check for BPF programs to elimiate error
> messages like:
> 
>     ERROR: do not initialise globals to 0
>     #19: FILE: samples/bpf/tracex1_kern.c:21:

Another possible option is simply to add --ignore=GLOBAL_INITIALISERS
to the checkpatch command line for these files.

> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
[]
> @@ -4323,7 +4323,11 @@ sub process {
>  		}
>  
> 
>  # check for global initialisers.
> -		if ($line =~ /^\+$Type\s*$Ident(?:\s+$Modifier)*\s*=\s*($zero_initializer)\s*;/) {
> +# Do not apply to BPF programs (tools/testing/selftests/bpf/progs/*.c, samples/bpf/*_kern.c, *.bpf.c).
> +		if ($line =~ /^\+$Type\s*$Ident(?:\s+$Modifier)*\s*=\s*($zero_initializer)\s*;/ &&
> +		    $realfile !~ /^tools\/testing\/selftests\/bpf\/progs\/.*\.c/ &&
> +		    $realfile !~ /^samples\/bpf\/.*_kern.c/ &&
> +		    $realfile !~ /.bpf.c$/) {
>  			if (ERROR("GLOBAL_INITIALISERS",
>  				  "do not initialise globals to $1\n" . $herecurr) &&
>  			    $fix) {