linux-kernel - Re: [PATCH v2] remoteproc: stm32: improve debug using dev_err

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9d12a62c-ba39-4943-d9c4-9e3da8ef947f@foss.st.com>
Date:   Tue, 9 Feb 2021 09:35:47 +0100
From:   Arnaud POULIQUEN <arnaud.pouliquen@...s.st.com>
To:     Bjorn Andersson <bjorn.andersson@...aro.org>,
        Ohad Ben-Cohen <ohad@...ery.com>,
        Mathieu Poirier <mathieu.poirier@...aro.org>
CC:     <linux-remoteproc@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linux-stm32@...md-mailman.stormreply.com>
Subject: Re: [PATCH v2] remoteproc: stm32: improve debug using dev_err_probe

Hi,

Gentle reminder, in case it has been forgotten.

Thanks,
Arnaud

On 12/17/20 3:41 PM, Arnaud Pouliquen wrote:
> From: Arnaud Pouliquen <arnaud.pouliquen@...s-st.com>
> 
> When possible use dev_err_probe help to properly deal with the
> PROBE_DEFER error.
> The benefit is that DEFER issue will be logged in the devices_deferred
> debugfs file.
> 
> Signed-off-by: Arnaud Pouliquen <arnaud.pouliquen@...s-st.com>
> ---
> V1 to V2: As suggested by Ahmad Fatoum use dev_err_probe to deal with
>           deferred cases
> 
> V1: https://www.spinics.net/lists/kernel/msg3765884.html
> ---
> 
>  drivers/remoteproc/stm32_rproc.c | 23 +++++++++++++----------
>  1 file changed, 13 insertions(+), 10 deletions(-)
> 
> diff --git a/drivers/remoteproc/stm32_rproc.c b/drivers/remoteproc/stm32_rproc.c
> index a180aeae9675..ccb3c14a0023 100644
> --- a/drivers/remoteproc/stm32_rproc.c
> +++ b/drivers/remoteproc/stm32_rproc.c
> @@ -370,8 +370,13 @@ static int stm32_rproc_request_mbox(struct rproc *rproc)
>  
>  		ddata->mb[i].chan = mbox_request_channel_byname(cl, name);
>  		if (IS_ERR(ddata->mb[i].chan)) {
> -			if (PTR_ERR(ddata->mb[i].chan) == -EPROBE_DEFER)
> +			if (PTR_ERR(ddata->mb[i].chan) == -EPROBE_DEFER) {
> +				dev_err_probe(dev->parent,
> +					      PTR_ERR(ddata->mb[i].chan),
> +					      "failed to request mailbox %s\n",
> +					      name);
>  				goto err_probe;
> +			}
>  			dev_warn(dev, "cannot get %s mbox\n", name);
>  			ddata->mb[i].chan = NULL;
>  		}
> @@ -592,15 +597,14 @@ static int stm32_rproc_parse_dt(struct platform_device *pdev,
>  
>  	irq = platform_get_irq(pdev, 0);
>  	if (irq == -EPROBE_DEFER)
> -		return -EPROBE_DEFER;
> +		return dev_err_probe(dev, irq, "failed to get interrupt\n");
>  
>  	if (irq > 0) {
>  		err = devm_request_irq(dev, irq, stm32_rproc_wdg, 0,
>  				       dev_name(dev), pdev);
> -		if (err) {
> -			dev_err(dev, "failed to request wdg irq\n");
> -			return err;
> -		}
> +		if (err)
> +			return dev_err_probe(dev, err,
> +					     "failed to request wdg irq\n");
>  
>  		ddata->wdg_irq = irq;
>  
> @@ -613,10 +617,9 @@ static int stm32_rproc_parse_dt(struct platform_device *pdev,
>  	}
>  
>  	ddata->rst = devm_reset_control_get_by_index(dev, 0);
> -	if (IS_ERR(ddata->rst)) {
> -		dev_err(dev, "failed to get mcu reset\n");
> -		return PTR_ERR(ddata->rst);
> -	}
> +	if (IS_ERR(ddata->rst))
> +		return dev_err_probe(dev, PTR_ERR(ddata->rst),
> +				     "failed to get mcu_reset\n");
>  
>  	/*
>  	 * if platform is secured the hold boot bit must be written by
>