linux-kernel - Re: [PATCH] selftests: breakpoints: Use correct error messages in breakpoint_test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <db7c4310-503b-f84f-99a6-0d8d58da99b6@linuxfoundation.org>
Date:   Mon, 8 Feb 2021 17:05:52 -0700
From:   Shuah Khan <skhan@...uxfoundation.org>
To:     Tiezhu Yang <yangtiezhu@...ngson.cn>, Shuah Khan <shuah@...nel.org>
Cc:     linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org,
        Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH] selftests: breakpoints: Use correct error messages in
 breakpoint_test_arm64.c

On 2/4/21 11:33 PM, Tiezhu Yang wrote:
> When call ptrace(PTRACE_CONT, ...) failed, use correct error messages.
> 
> Signed-off-by: Tiezhu Yang <yangtiezhu@...ngson.cn>
> ---
>   tools/testing/selftests/breakpoints/breakpoint_test_arm64.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/testing/selftests/breakpoints/breakpoint_test_arm64.c b/tools/testing/selftests/breakpoints/breakpoint_test_arm64.c
> index ad41ea6..e704181 100644
> --- a/tools/testing/selftests/breakpoints/breakpoint_test_arm64.c
> +++ b/tools/testing/selftests/breakpoints/breakpoint_test_arm64.c
> @@ -145,7 +145,7 @@ static bool run_test(int wr_size, int wp_size, int wr, int wp)
>   
>   	if (ptrace(PTRACE_CONT, pid, NULL, NULL) < 0) {
>   		ksft_print_msg(
> -			"ptrace(PTRACE_SINGLESTEP) failed: %s\n",
> +			"ptrace(PTRACE_CONT) failed: %s\n",
>   			strerror(errno));
>   		return false;
>   	}
> @@ -159,7 +159,7 @@ static bool run_test(int wr_size, int wp_size, int wr, int wp)
>   	}
>   	alarm(0);
>   	if (WIFEXITED(status)) {
> -		ksft_print_msg("child did not single-step\n");
> +		ksft_print_msg("child exited prematurely\n");
>   		return false;
>   	}
>   	if (!WIFSTOPPED(status)) {
> 

Thank you. Applied to linux-kselftest next for 5.12-rc1

thanks,
-- Shuah