lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <90e31853-d3db-df51-b32e-bebd030e44d2@huawei.com> Date: Tue, 9 Feb 2021 09:04:35 +0800 From: Miaohe Lin <linmiaohe@...wei.com> To: Yafang Shao <laoar.shao@...il.com> CC: <linux-mm@...ck.org>, <linux-kernel@...r.kernel.org>, <andriy.shevchenko@...ux.intel.com>, <david@...hat.com>, <vbabka@...e.cz>, <willy@...radead.org>, <cl@...ux.com>, <penberg@...nel.org>, <rientjes@...gle.com>, <iamjoonsoo.kim@....com>, <akpm@...ux-foundation.org>, <pmladek@...e.com>, <rostedt@...dmis.org>, <sergey.senozhatsky@...il.com>, <joe@...ches.com> Subject: Re: [PATCH v3 1/3] mm, slub: use pGp to print page flags On 2021/2/8 18:14, Yafang Shao wrote: > As pGp has been already introduced in printk, we'd better use it to make > the output human readable. > > Before this change, the output is, > [ 6155.716018] INFO: Slab 0x000000004027dd4f objects=33 used=3 fp=0x000000008cd1579c flags=0x17ffffc0010200 > > While after this change, the output is, > [ 8846.517809] INFO: Slab 0x00000000f42a2c60 objects=33 used=3 fp=0x0000000060d32ca8 flags=0x17ffffc0010200(slab|head) > > Reviewed-by: David Hildenbrand <david@...hat.com> > Reviewed-by: Vlastimil Babka <vbabka@...e.cz> > Acked-by: David Rientjes <rientjes@...gle.com> > Acked-by: Christoph Lameter <cl@...ux.com> > Signed-off-by: Yafang Shao <laoar.shao@...il.com> LGTM. Thanks. Reviewed-by: Miaohe Lin <linmiaohe@...wei.com> > --- > mm/slub.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/mm/slub.c b/mm/slub.c > index 34dcc09e2ec9..87ff086e68a4 100644 > --- a/mm/slub.c > +++ b/mm/slub.c > @@ -638,8 +638,9 @@ void print_tracking(struct kmem_cache *s, void *object) > > static void print_page_info(struct page *page) > { > - pr_err("INFO: Slab 0x%p objects=%u used=%u fp=0x%p flags=0x%04lx\n", > - page, page->objects, page->inuse, page->freelist, page->flags); > + pr_err("INFO: Slab 0x%p objects=%u used=%u fp=0x%p flags=%#lx(%pGp)\n", > + page, page->objects, page->inuse, page->freelist, > + page->flags, &page->flags); > > } > >
Powered by blists - more mailing lists