linux-kernel - Re: [PATCH v4] mfd: da9063: Support SMBus and I2C mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210209104050.GB9698@ninjato>
Date:   Tue, 9 Feb 2021 11:40:50 +0100
From:   Wolfram Sang <wsa@...nel.org>
To:     Mark Jonas <mark.jonas@...bosch.com>
Cc:     Support Opensource <support.opensource@...semi.com>,
        Lee Jones <lee.jones@...aro.org>, linux-kernel@...r.kernel.org,
        linux-i2c@...r.kernel.org, Adam.Thomson.Opensource@...semi.com,
        stwiss.opensource@...semi.com, marek.vasut@...il.com,
        tingquan.ruan@...bosch.com, hubert.streidl@...bosch.com
Subject: Re: [PATCH v4] mfd: da9063: Support SMBus and I2C mode

On Mon, Feb 08, 2021 at 04:27:58PM +0100, Mark Jonas wrote:
> From: Hubert Streidl <hubert.streidl@...bosch.com>
> 
> By default the PMIC DA9063 2-wire interface is SMBus compliant. This
> means the PMIC will automatically reset the interface when the clock
> signal ceases for more than the SMBus timeout of 35 ms.
> 
> If the I2C driver / device is not capable of creating atomic I2C
> transactions, a context change can cause a ceasing of the clock signal.
> This can happen if for example a real-time thread is scheduled. Then
> the DA9063 in SMBus mode will reset the 2-wire interface. Subsequently
> a write message could end up in the wrong register. This could cause
> unpredictable system behavior.
> 
> The DA9063 PMIC also supports an I2C compliant mode for the 2-wire
> interface. This mode does not reset the interface when the clock
> signal ceases. Thus the problem depicted above does not occur.
> 
> This patch tests for the bus functionality "I2C_FUNC_I2C". It can
> reasonably be assumed that the bus cannot obey SMBus timings if
> this functionality is set. SMBus commands most probably are emulated
> in this case which is prone to the latency issue described above.
> 
> This patch enables the I2C bus mode if I2C_FUNC_I2C is set or
> otherwise enables the SMBus mode for a native SMBus controller
> which doesn't have I2C_FUNC_I2C set.
> 
> Signed-off-by: Hubert Streidl <hubert.streidl@...bosch.com>
> Signed-off-by: Mark Jonas <mark.jonas@...bosch.com>

From I2C highlevel view, this looks good:

Reviewed-by: Wolfram Sang <wsa+renesas@...g-engineering.com>


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)