linux-kernel - Re: [PATCH] i2c: mv64xxx: Fix check for missing clock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210209104245.GC9698@ninjato>
Date:   Tue, 9 Feb 2021 11:42:45 +0100
From:   Wolfram Sang <wsa@...nel.org>
To:     Samuel Holland <samuel@...lland.org>
Cc:     Gregory CLEMENT <gregory.clement@...tlin.com>,
        linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org,
        Dan Carpenter <dan.carpenter@...cle.com>
Subject: Re: [PATCH] i2c: mv64xxx: Fix check for missing clock

On Mon, Feb 08, 2021 at 12:19:22AM -0600, Samuel Holland wrote:
> In commit e5c02cf54154 ("i2c: mv64xxx: Add runtime PM support"), error
> pointers to optional clocks were replaced by NULL to simplify the resume
> callback implementation. However, that commit missed that the IS_ERR
> check in mv64xxx_of_config should be replaced with a NULL check. As a
> result, the check always passes, even for an invalid device tree.
> 
> Fixes: e5c02cf54154 ("i2c: mv64xxx: Add runtime PM support")
> Reported-by: Dan Carpenter <dan.carpenter@...cle.com>
> Signed-off-by: Samuel Holland <samuel@...lland.org>

Added "RPM" to $subject and applied to for-next, thanks!


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)