linux-kernel - [PATCH v2 2/4] hwmon: Use subdir-ccflags-* to inherit debug flag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 9 Feb 2021 19:08:17 +0800
From:   Yicong Yang <yangyicong@...ilicon.com>
To:     <gregkh@...uxfoundation.org>, <jdelvare@...e.com>,
        <linux@...ck-us.net>, <giometti@...eenne.com>, <abbotti@....co.uk>,
        <hsweeten@...ionengravers.com>, <kw@...ux.com>,
        <helgaas@...nel.org>, <linux-kernel@...r.kernel.org>,
        <linux-pm@...r.kernel.org>, <linux-hwmon@...r.kernel.org>,
        <devel@...verdev.osuosl.org>, <linux-kbuild@...r.kernel.org>,
        <masahiroy@...nel.org>, <michal.lkml@...kovi.net>
CC:     <prime.zeng@...wei.com>, <yangyicong@...ilicon.com>,
        <linuxarm@...neuler.org>
Subject: [PATCH v2 2/4] hwmon: Use subdir-ccflags-* to inherit debug flag

From: Junhao He <hejunhao2@...ilicon.com>

We use ccflags-$(CONFIG_HWMON_DEBUG_CHIP) for the debug
message in drivers/hwmon, but the DEBUG flag will not pass to
the subdirectory.

Considering CONFIG_HWMON_DEBUG_CHIP intends to have DEBUG
recursively in driver/hwmon. It will be clearer
to use subdir-ccflags-* instead of ccflags-* to inherit
the debug settings from Kconfig when traversing subdirectories,
and it will avoid omittance of DEBUG define when debug messages
added in the subdirectories.

Suggested-by: Bjorn Helgaas <bhelgaas@...gle.com>
Signed-off-by: Junhao He <hejunhao2@...ilicon.com>
Signed-off-by: Yicong Yang <yangyicong@...ilicon.com>
---
 drivers/hwmon/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/hwmon/Makefile b/drivers/hwmon/Makefile
index 09a86c5..1c0c089 100644
--- a/drivers/hwmon/Makefile
+++ b/drivers/hwmon/Makefile
@@ -201,5 +201,5 @@ obj-$(CONFIG_SENSORS_XGENE)	+= xgene-hwmon.o
 obj-$(CONFIG_SENSORS_OCC)	+= occ/
 obj-$(CONFIG_PMBUS)		+= pmbus/
 
-ccflags-$(CONFIG_HWMON_DEBUG_CHIP) := -DDEBUG
+subdir-ccflags-$(CONFIG_HWMON_DEBUG_CHIP) := -DDEBUG
 
-- 
2.8.1