linux-kernel - Re: [PATCH] USB: serial: drop bogus to_usb_serial

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YCJ9IgwSLyNmPq5B@hovoldconsulting.com>
Date:   Tue, 9 Feb 2021 13:16:34 +0100
From:   Johan Hovold <johan@...nel.org>
To:     Uwe Kleine-König <uwe@...ine-koenig.org>
Cc:     linux-usb@...r.kernel.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] USB: serial: drop bogus to_usb_serial_port() checks

On Mon, Feb 08, 2021 at 06:06:38PM +0100, Uwe Kleine-König wrote:
> On 2/8/21 4:48 PM, Johan Hovold wrote:
> > The to_usb_serial_port() macro is implemented using container_of() so
> > there's no need to check for NULL.
> > 
> > Note that neither bus match() or probe() is ever called with a NULL
> > struct device pointer so the checks weren't just misplaced.
> > 
> > Signed-off-by: Johan Hovold <johan@...nel.org>
> 
> Reviewed-by: Uwe Kleine-König <uwe@...ine-koenig.org>

Thanks Uwe and Greg for reviewing. Now applied.

Johan

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)