linux-kernel - Re: [PATCH v5 2/7] gpio: ep93xx: Fix single irqchip with multi gpiochips

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5450294.DvuYhMxLoT@redslave>
Date:   Tue, 09 Feb 2021 15:33:56 +0300
From:   Nikita Shubin <nikita.shubin@...uefel.me>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     Linus Walleij <linus.walleij@...aro.org>,
        Bartosz Golaszewski <bgolaszewski@...libre.com>,
        Alexander Sverdlin <alexander.sverdlin@...il.com>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v5 2/7] gpio: ep93xx: Fix single irqchip with multi gpiochips

Hello Andy.

On Monday, 8 February 2021 16:20:17 MSK Andy Shevchenko wrote:
>On Mon, Feb 8, 2021 at 11:00 AM Nikita Shubin 
<nikita.shubin@...uefel.me> wrote:
>> Fixes the following warnings which results in interrupts disabled on
>> port B/F:
>> 
>> gpio gpiochip1: (B): detected irqchip that is shared with multiple
>> gpiochips: please fix the driver. gpio gpiochip5: (F): detected
>> irqchip that is shared with multiple gpiochips: please fix the
>> driver.
>> 
>> - added separate irqchip for each interrupt capable gpiochip
>> - provided unique names for each irqchip
>
>...
>
>> +static void ep93xx_init_irq_chip(struct device *dev, struct irq_chip
>> *ic, const char *label) +{
>> 
>> +       ic->name = devm_kasprintf(dev, GFP_KERNEL, "gpio-irq-%s",
>> label);
>Is the label being NULL okay?

The label is taken from ep93xx_gpio_banks[], so unless we explicitly 
pass zero to ep93xx_init_irq_chip(), we are ok.

>
>> +       ic->irq_ack = ep93xx_gpio_irq_ack;
>> +       ic->irq_mask_ack = ep93xx_gpio_irq_mask_ack;
>> +       ic->irq_mask = ep93xx_gpio_irq_mask;
>> +       ic->irq_unmask = ep93xx_gpio_irq_unmask;
>> +       ic->irq_set_type = ep93xx_gpio_irq_type;
>> +}
>
>...
>
>> -               girq->chip = &ep93xx_gpio_irq_chip;
>
>I don't see where you remove that static structure.

Good catch - thank you very much, also i noticed that i forgot to switch 
IRQ chip in irq_set_chip_and_handler() for port F.