linux-kernel - Re: [PATCH mips-fixes] MIPS: compressed: fix build with enabled UBSAN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210209123817.GE11264@alpha.franken.de>
Date:   Tue, 9 Feb 2021 13:38:17 +0100
From:   Thomas Bogendoerfer <tsbogend@...ha.franken.de>
To:     Alexander Lobakin <alobakin@...me>
Cc:     Paul Cercueil <paul@...pouillou.net>,
        Youling Tang <tangyouling@...ngson.cn>,
        Jiaxun Yang <jiaxun.yang@...goat.com>,
        Xingxing Su <suxingxing@...ngson.cn>,
        Huacai Chen <chenhuacai@...nel.org>,
        Paul Burton <paulburton@...nel.org>,
        Hassan Naveed <hnaveed@...ecomp.com>,
        linux-mips@...r.kernel.org, stable@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH mips-fixes] MIPS: compressed: fix build with enabled UBSAN

On Mon, Feb 08, 2021 at 12:37:42PM +0000, Alexander Lobakin wrote:
> Commit 1e35918ad9d1 ("MIPS: Enable Undefined Behavior Sanitizer
> UBSAN") added a possibility to build the entire kernel with UBSAN
> instrumentation for MIPS, with the exception for VDSO.
> However, self-extracting head wasn't been added to exceptions, so
> this occurs:
> 
> mips-alpine-linux-musl-ld: arch/mips/boot/compressed/decompress.o:
> in function `FSE_buildDTable_wksp':
> decompress.c:(.text.FSE_buildDTable_wksp+0x278): undefined reference
> to `__ubsan_handle_shift_out_of_bounds'
> mips-alpine-linux-musl-ld: decompress.c:(.text.FSE_buildDTable_wksp+0x2a8):
> undefined reference to `__ubsan_handle_shift_out_of_bounds'
> mips-alpine-linux-musl-ld: decompress.c:(.text.FSE_buildDTable_wksp+0x2c4):
> undefined reference to `__ubsan_handle_shift_out_of_bounds'
> mips-alpine-linux-musl-ld: arch/mips/boot/compressed/decompress.o:
> decompress.c:(.text.FSE_buildDTable_raw+0x9c): more undefined references
> to `__ubsan_handle_shift_out_of_bounds' follow
> 
> Add UBSAN_SANITIZE := n to mips/boot/compressed/Makefile to exclude
> it from instrumentation scope and fix this issue.
> 
> Fixes: 1e35918ad9d1 ("MIPS: Enable Undefined Behavior Sanitizer UBSAN")
> Cc: stable@...r.kernel.org # 5.0+
> Signed-off-by: Alexander Lobakin <alobakin@...me>
> ---
>  arch/mips/boot/compressed/Makefile | 1 +
>  1 file changed, 1 insertion(+)

applied to mips-next.

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]