linux-kernel - Re: [PATCH v2] perf script: Simplify bool conversion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YCKEbN52Z+a4+mhd@krava>
Date:   Tue, 9 Feb 2021 13:47:40 +0100
From:   Jiri Olsa <jolsa@...hat.com>
To:     Yang Li <yang.lee@...ux.alibaba.com>
Cc:     daniel@...earbox.net, peterz@...radead.org, mingo@...hat.com,
        acme@...nel.org, mark.rutland@....com,
        alexander.shishkin@...ux.intel.com, namhyung@...nel.org,
        ast@...nel.org, andrii@...nel.org, kafai@...com,
        songliubraving@...com, yhs@...com, john.fastabend@...il.com,
        kpsingh@...nel.org, linux-kernel@...r.kernel.org,
        netdev@...r.kernel.org, bpf@...r.kernel.org
Subject: Re: [PATCH v2] perf script: Simplify bool conversion

On Mon, Feb 08, 2021 at 04:45:36PM +0800, Yang Li wrote:
> Fix the following coccicheck warning:
> ./tools/perf/builtin-script.c:2789:36-41: WARNING: conversion to bool
> not needed here
> ./tools/perf/builtin-script.c:3237:48-53: WARNING: conversion to bool
> not needed here
> 
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@...ux.alibaba.com>

Acked-by: Jiri Olsa <jolsa@...hat.com>

thanks,
jirka

> ---
> 
> Change in v2:
> -Change the subject to "perf script"
> 
>  tools/perf/builtin-script.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/perf/builtin-script.c b/tools/perf/builtin-script.c
> index 42dad4a..3646a1c 100644
> --- a/tools/perf/builtin-script.c
> +++ b/tools/perf/builtin-script.c
> @@ -2786,7 +2786,7 @@ static int parse_output_fields(const struct option *opt __maybe_unused,
>  				break;
>  		}
>  		if (i == imax && strcmp(tok, "flags") == 0) {
> -			print_flags = change == REMOVE ? false : true;
> +			print_flags = change != REMOVE;
>  			continue;
>  		}
>  		if (i == imax) {
> @@ -3234,7 +3234,7 @@ static char *get_script_path(const char *script_root, const char *suffix)
>  
>  static bool is_top_script(const char *script_path)
>  {
> -	return ends_with(script_path, "top") == NULL ? false : true;
> +	return ends_with(script_path, "top") != NULL;
>  }
>  
>  static int has_required_arg(char *script_path)
> -- 
> 1.8.3.1
>