linux-kernel - Re: [PATCH net-next v2] net: phy: broadcom: remove BCM5482 1000Base-BX support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YCHlnr7dFWuECcqv@lunn.ch>
Date:   Tue, 9 Feb 2021 02:30:06 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Michael Walle <michael@...le.cc>
Cc:     bcm-kernel-feedback-list@...adcom.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Florian Fainelli <f.fainelli@...il.com>,
        Heiner Kallweit <hkallweit1@...il.com>,
        Russell King <linux@...linux.org.uk>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>
Subject: Re: [PATCH net-next v2] net: phy: broadcom: remove BCM5482
 1000Base-BX support

On Tue, Feb 09, 2021 at 12:17:06AM +0100, Michael Walle wrote:
> It is nowhere used in the kernel. It also seems to be lacking the
> proper fiber advertise flags. Remove it.

Maybe also remove the #define for PHY_BCM_FLAGS_MODE_1000BX? Maybe
there is an out of tree driver using this? By removing the #define, it
will fail at compile time, making it obvious the support has been
removed?

Otherwise:

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew