linux-kernel - Re: [PATCH v3 6/7] ASoC: codecs: lpass-tx-macro: add support for lpass tx macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202102090902.CMppFuvv-lkp@intel.com>
Date:   Tue, 9 Feb 2021 09:43:20 +0800
From:   kernel test robot <lkp@...el.com>
To:     Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
        broonie@...nel.org
Cc:     kbuild-all@...ts.01.org, devicetree@...r.kernel.org,
        alsa-devel@...a-project.org, lgirdwood@...il.com,
        linux-kernel@...r.kernel.org, robh+dt@...nel.org,
        Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
Subject: Re: [PATCH v3 6/7] ASoC: codecs: lpass-tx-macro: add support for
 lpass tx macro

Hi Srinivas,

I love your patch! Perhaps something to improve:

[auto build test WARNING on asoc/for-next]
[also build test WARNING on v5.11-rc6 next-20210125]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Srinivas-Kandagatla/ASoC-codecs-add-support-for-LPASS-Codec-TX-and-RX-macros/20210209-072204
base:   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
config: arc-allyesconfig (attached as .config)
compiler: arceb-elf-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/92f218ff557dc250c8a13c5715131e0077fae11b
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Srinivas-Kandagatla/ASoC-codecs-add-support-for-LPASS-Codec-TX-and-RX-macros/20210209-072204
        git checkout 92f218ff557dc250c8a13c5715131e0077fae11b
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arc 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   sound/soc/codecs/lpass-tx-macro.c: In function 'tx_macro_tx_hpf_corner_freq_callback':
>> sound/soc/codecs/lpass-tx-macro.c:656:15: warning: variable 'adc_n' set but not used [-Wunused-but-set-variable]
     656 |  u16 adc_reg, adc_n;
         |               ^~~~~


vim +/adc_n +656 sound/soc/codecs/lpass-tx-macro.c

   647	
   648	static void tx_macro_tx_hpf_corner_freq_callback(struct work_struct *work)
   649	{
   650		struct delayed_work *hpf_delayed_work;
   651		struct hpf_work *hpf_work;
   652		struct tx_macro *tx;
   653		struct snd_soc_component *component;
   654		u16 dec_cfg_reg, hpf_gate_reg;
   655		u8 hpf_cut_off_freq;
 > 656		u16 adc_reg, adc_n;
   657	
   658		hpf_delayed_work = to_delayed_work(work);
   659		hpf_work = container_of(hpf_delayed_work, struct hpf_work, dwork);
   660		tx = hpf_work->tx;
   661		component = tx->component;
   662		hpf_cut_off_freq = hpf_work->hpf_cut_off_freq;
   663	
   664		dec_cfg_reg = CDC_TXn_TX_PATH_CFG0(hpf_work->decimator);
   665		hpf_gate_reg = CDC_TXn_TX_PATH_SEC2(hpf_work->decimator);
   666	
   667		if (is_amic_enabled(component, hpf_work->decimator)) {
   668			adc_reg = CDC_TX_INP_MUX_ADC_MUXn_CFG0(hpf_work->decimator);
   669			adc_n = snd_soc_component_read(component, adc_reg) &
   670					CDC_TX_MACRO_SWR_MIC_MUX_SEL_MASK;
   671			/* analog mic clear TX hold */
   672			snd_soc_component_write_field(component,
   673					dec_cfg_reg,
   674					CDC_TXn_HPF_CUT_FREQ_MASK,
   675					hpf_cut_off_freq);
   676			snd_soc_component_update_bits(component, hpf_gate_reg,
   677						      CDC_TXn_HPF_F_CHANGE_MASK |
   678						      CDC_TXn_HPF_ZERO_GATE_MASK,
   679						      0x02);
   680			snd_soc_component_update_bits(component, hpf_gate_reg,
   681						      CDC_TXn_HPF_F_CHANGE_MASK |
   682						      CDC_TXn_HPF_ZERO_GATE_MASK,
   683						      0x01);
   684		} else {
   685			snd_soc_component_write_field(component, dec_cfg_reg,
   686						      CDC_TXn_HPF_CUT_FREQ_MASK,
   687						      hpf_cut_off_freq);
   688			snd_soc_component_write_field(component, hpf_gate_reg,
   689						      CDC_TXn_HPF_F_CHANGE_MASK, 0x1);
   690			/* Minimum 1 clk cycle delay is required as per HW spec */
   691			usleep_range(1000, 1010);
   692			snd_soc_component_write_field(component, hpf_gate_reg,
   693						      CDC_TXn_HPF_F_CHANGE_MASK, 0x0);
   694		}
   695	}
   696	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (67247 bytes)