linux-kernel - Re: [PATCH v2] mm: cma: Print region name on failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <37be751f-8c11-fd5a-a57f-a5e0599e2420@redhat.com>
Date:   Tue, 9 Feb 2021 17:06:38 +0100
From:   David Hildenbrand <david@...hat.com>
To:     Georgi Djakov <georgi.djakov@...aro.org>,
        akpm@...ux-foundation.org, linux-mm@...ck.org
Cc:     rdunlap@...radead.org, pdaly@...eaurora.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] mm: cma: Print region name on failure

On 09.02.21 15:24, Georgi Djakov wrote:
> From: Patrick Daly <pdaly@...eaurora.org>
> 
> Print the name of the CMA region for convenience. This is useful
> information to have when cma_alloc() fails.
> 
> Signed-off-by: Patrick Daly <pdaly@...eaurora.org>
> Signed-off-by: Georgi Djakov <georgi.djakov@...aro.org>
> ---
> v2:
>   * Print the "count" variable, as it was originally in the code. (Randy)
>   * Fix spelling s/convienience/convenience/ in the commit text (Randy)
> 
> v1: https://lore.kernel.org/r/20210208115200.20286-1-georgi.djakov@linaro.org/
> 
>   mm/cma.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/mm/cma.c b/mm/cma.c
> index 23d4a97c834a..54eee2119822 100644
> --- a/mm/cma.c
> +++ b/mm/cma.c
> @@ -500,8 +500,8 @@ struct page *cma_alloc(struct cma *cma, size_t count, unsigned int align,
>   	}
>   
>   	if (ret && !no_warn) {
> -		pr_err("%s: alloc failed, req-size: %zu pages, ret: %d\n",
> -			__func__, count, ret);
> +		pr_err("%s: %s: alloc failed, req-size: %zu pages, ret: %d\n",
> +		       __func__, cma->name, count, ret);
>   		cma_debug_show_areas(cma);
>   	}
>   
> 

Reviewed-by: David Hildenbrand <david@...hat.com>

-- 
Thanks,

David / dhildenb