linux-kernel - Re: [PATCH] Revert "dts: phy: add GPIO number and active state used for phy reset"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <877dngjdi1.fsf@igel.home>
Date:   Wed, 10 Feb 2021 13:47:34 +0100
From:   Andreas Schwab <schwab@...ux-m68k.org>
To:     Palmer Dabbelt <palmer@...belt.com>
Cc:     devicetree@...r.kernel.org, aou@...s.berkeley.edu,
        anup@...infault.org, Palmer Dabbelt <palmerdabbelt@...gle.com>,
        linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        yash.shah@...ive.com, robh+dt@...nel.org, sagar.kadam@...ive.com,
        Paul Walmsley <paul.walmsley@...ive.com>,
        linux-riscv@...ts.infradead.org, kernel-team@...roid.com
Subject: Re: [PATCH] Revert "dts: phy: add GPIO number and active state used
 for phy reset"

On Feb 04 2021, Palmer Dabbelt wrote:

> From: Palmer Dabbelt <palmerdabbelt@...gle.com>
>
> VSC8541 phys need a special reset sequence, which the driver doesn't
> currentlny support.  As a result enabling the reset via GPIO essentially
> guarnteees that the device won't work correctly.
>
> This reverts commit a0fa9d727043da2238432471e85de0bdb8a8df65.
>
> Fixes: a0fa9d727043 ("dts: phy: add GPIO number and active state used for phy reset")
> Cc: stable@...r.kernel.org
> Signed-off-by: Palmer Dabbelt <palmerdabbelt@...gle.com>

This fixes ethernet on the HiFive Unleashed with 5.10.12.

Andreas.

-- 
Andreas Schwab, schwab@...ux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510  2552 DF73 E780 A9DA AEC1
"And now for something completely different."