linux-kernel - Re: [PATCH] gpio: GPIO_MXS should not default to y, unconditionally

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMpxmJV5vMuyA8bc4MJfwPAKM-0vKQP2oAPZTigGtDtHvoaByg@mail.gmail.com>
Date:   Wed, 10 Feb 2021 14:25:21 +0100
From:   Bartosz Golaszewski <bgolaszewski@...libre.com>
To:     Geert Uytterhoeven <geert+renesas@...der.be>
Cc:     Anson Huang <Anson.Huang@....com>, Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Linus Walleij <linus.walleij@...aro.org>,
        Fabio Estevam <festevam@...il.com>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        NXP Linux Team <linux-imx@....com>,
        linux-gpio <linux-gpio@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] gpio: GPIO_MXS should not default to y, unconditionally

On Mon, Feb 8, 2021 at 3:51 PM Geert Uytterhoeven
<geert+renesas@...der.be> wrote:
>
> Merely enabling CONFIG_COMPILE_TEST should not enable additional code.
> To fix this, restrict the automatic enabling of GPIO_MXS to ARCH_MXS,
> and ask the user in case of compile-testing.
>
> Fixes: 6876ca311bfca5d7 ("gpio: mxs: add COMPILE_TEST support for GPIO_MXS")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>
> ---
>  drivers/gpio/Kconfig | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
> index 5fdf526fe973da38..412728ff2ab45c0d 100644
> --- a/drivers/gpio/Kconfig
> +++ b/drivers/gpio/Kconfig
> @@ -442,8 +442,9 @@ config GPIO_MXC
>         select GENERIC_IRQ_CHIP
>
>  config GPIO_MXS
> -       def_bool y
> +       bool "Freescale MXS GPIO support" if COMPILE_TEST
>         depends on ARCH_MXS || COMPILE_TEST
> +       default y if ARCH_MXS
>         select GPIO_GENERIC
>         select GENERIC_IRQ_CHIP
>
> --
> 2.25.1
>

Applied, thanks!

Bartosz