linux-kernel - Re: [next] [mips] spinlock.h:17:28: error: redefinition of 'queued_spin

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 10 Feb 2021 10:02:40 -0500
From:   Waiman Long <longman@...hat.com>
To:     Naresh Kamboju <naresh.kamboju@...aro.org>,
        linux-mips@...r.kernel.org,
        Linux-Next Mailing List <linux-next@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>,
        lkft-triage@...ts.linaro.org
Cc:     Paul Burton <paul.burton@...s.com>, Will Deacon <will@...nel.org>,
        Will Deacon <will.deacon@....com>,
        Stephen Rothwell <sfr@...b.auug.org.au>,
        Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
        Ingo Molnar <mingo@...hat.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Boqun Feng <boqun.feng@...il.com>
Subject: Re: [next] [mips] spinlock.h:17:28: error: redefinition of
 'queued_spin_unlock'

On 2/10/21 12:30 AM, Naresh Kamboju wrote:
> While building Linux next tag 20210209 mips uImage.gz failed with below configs
>
>    - mips (cavium_octeon_defconfig) with gcc-8, gcc-9 and gcc-10 - FAILED
>    - mips (malta_defconfig) with gcc-8, gcc-9 and gcc-10 - FAILED
>    - mips (nlm_xlp_defconfig) with gcc-8, gcc-9 and gcc-10 - FAILED
>    - mips (defconfig) with gcc-8, gcc-9 and gcc-10 - FAILED
>
> make --silent --keep-going --jobs=8
> O=/home/tuxbuild/.cache/tuxmake/builds/1/tmp ARCH=mips
> CROSS_COMPILE=mips-linux-gnu- 'CC=sccache mips-linux-gnu-gcc'
> 'HOSTCC=sccache gcc' uImage.gz
> In file included from /include/linux/spinlock.h:90,
>                   from /include/linux/ipc.h:5,
>                   from /include/uapi/linux/sem.h:5,
>                   from /include/linux/sem.h:5,
>                   from /include/linux/compat.h:14,
>                   from /arch/mips/kernel/asm-offsets.c:12:
> /arch/mips/include/asm/spinlock.h:17:28: error: redefinition of
> 'queued_spin_unlock'
>     17 | #define queued_spin_unlock queued_spin_unlock
>        |                            ^~~~~~~~~~~~~~~~~~
>
> Reported-by: Naresh Kamboju <naresh.kamboju@...aro.org>
>
> build link,
> https://builds.tuxbuild.com/1oF9lkBAeWM2WvR11O2Yun8ERNT/
>
I have just posted a patch to reorder qspinlock.h and qrwlock.h include 
ordering. Hopefully that can fix the compilation problem though I don't 
have a mips building environment to verify that.

Cheers,
Longman