linux-kernel - Re: [PATCH 3/4] asm-generic: div64: Remove always-true __div64_const32_is

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 10 Feb 2021 16:11:17 +0100
From:   Arnd Bergmann <arnd@...nel.org>
To:     Geert Uytterhoeven <geert+renesas@...der.be>
Cc:     Russell King <linux@...linux.org.uk>,
        Michal Simek <monstr@...str.eu>, Arnd Bergmann <arnd@...db.de>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        linux-arch <linux-arch@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 3/4] asm-generic: div64: Remove always-true __div64_const32_is_OK()

On Wed, Feb 10, 2021 at 3:11 PM Geert Uytterhoeven
<geert+renesas@...der.be> wrote:
>
> Since commit cafa0010cd51fb71 ("Raise the minimum required gcc version
> to 4.6"), the kernel can no longer be compiled using gcc-3.
> Hence __div64_const32_is_OK() is always true, and the corresponding
> check can thus be removed.
>
> While at it, remove the whitespace error that hurts my eyes, and add the
> missing curly braces for the final else statement, as per coding style.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>
> ---
>  include/asm-generic/div64.h | 14 ++++----------

Acked-by: Arnd Bergmann <arnd@...db.de>