linux-kernel - Re: [PATCH 1/2] bfq: remove some useless logic of bfq_update_next_in

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210210152034.puimoewzgtnnp2zl@spock.localdomain>
Date:   Wed, 10 Feb 2021 16:20:34 +0100
From:   Oleksandr Natalenko <oleksandr@...alenko.name>
To:     Paolo Valente <paolo.valente@...aro.org>
Cc:     Chunguang Xu <brookxu.cn@...il.com>, axboe@...nel.dk,
        linux-block@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] bfq: remove some useless logic of
 bfq_update_next_in_service()

On Wed, Feb 10, 2021 at 12:13:29PM +0100, Paolo Valente wrote:
> 
> 
> > Il giorno 29 gen 2021, alle ore 11:51, Chunguang Xu <brookxu.cn@...il.com> ha scritto:
> > 
> > From: Chunguang Xu <brookxu@...cent.com>
> > 
> > The if statement at the end of the function is obviously useless,
> > maybe we can delete it.
> > 
> 
> Thanks for spotting this mistake.
> 
> Acked-by: Paolo Valente <paolo.valente@...aro.org>
> 
> > Signed-off-by: Chunguang Xu <brookxu@...cent.com>
> > ---
> > block/bfq-wf2q.c | 3 ---
> > 1 file changed, 3 deletions(-)
> > 
> > diff --git a/block/bfq-wf2q.c b/block/bfq-wf2q.c
> > index 26776bd..070e34a 100644
> > --- a/block/bfq-wf2q.c
> > +++ b/block/bfq-wf2q.c
> > @@ -137,9 +137,6 @@ static bool bfq_update_next_in_service(struct bfq_sched_data *sd,
> > 
> > 	sd->next_in_service = next_in_service;
> > 
> > -	if (!next_in_service)
> > -		return parent_sched_may_change;
> > -

Unless I'm missing something, this has already been fixed here:

https://git.kernel.dk/cgit/linux-block/commit/?h=for-5.12/block&id=1a23e06cdab2be07cbda460c6417d7de564c48e6

> > 	return parent_sched_may_change;
> > }
> > 
> > -- 
> > 1.8.3.1
> > 
> 

-- 
  Oleksandr Natalenko (post-factum)