linux-kernel - Re: [PATCH 2/2] bfq: amend the function name of bfq_may_expire_for_budg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210210153738.pdsiqnmucq5v5cck@spock.localdomain>
Date:   Wed, 10 Feb 2021 16:37:38 +0100
From:   Oleksandr Natalenko <oleksandr@...alenko.name>
To:     Paolo Valente <paolo.valente@...aro.org>
Cc:     Chunguang Xu <brookxu.cn@...il.com>, axboe@...nel.dk,
        linux-block@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] bfq: amend the function name of
 bfq_may_expire_for_budg_timeout()

On Wed, Feb 10, 2021 at 12:13:59PM +0100, Paolo Valente wrote:
> 
> 
> > Il giorno 29 gen 2021, alle ore 11:51, Chunguang Xu <brookxu.cn@...il.com> ha scritto:
> > 
> > From: Chunguang Xu <brookxu@...cent.com>
> > 
> > The function name bfq_may_expire_for_budg_timeout() may be misspelled,
> > try to fix it.
> > 
> 
> Ok for me to make this name longer.
> 
> Thanks,
> Paolo
> 
> > Signed-off-by: Chunguang Xu <brookxu@...cent.com>
> > ---
> > block/bfq-iosched.c | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> > 
> > diff --git a/block/bfq-iosched.c b/block/bfq-iosched.c
> > index 9e4eb0f..4f40c61 100644
> > --- a/block/bfq-iosched.c
> > +++ b/block/bfq-iosched.c
> > @@ -4061,7 +4061,7 @@ static bool bfq_bfqq_budget_timeout(struct bfq_queue *bfqq)
> >  * condition does not hold, or if the queue is slow enough to deserve
> >  * only to be kicked off for preserving a high throughput.
> >  */
> > -static bool bfq_may_expire_for_budg_timeout(struct bfq_queue *bfqq)
> > +static bool bfq_may_expire_for_budget_timeout(struct bfq_queue *bfqq)
> > {
> > 	bfq_log_bfqq(bfqq->bfqd, bfqq,
> > 		"may_budget_timeout: wait_request %d left %d timeout %d",
> > @@ -4350,7 +4350,7 @@ static struct bfq_queue *bfq_select_queue(struct bfq_data *bfqd)
> > 	 * on the case where bfq_bfqq_must_idle() returns true, in
> > 	 * bfq_completed_request().
> > 	 */
> > -	if (bfq_may_expire_for_budg_timeout(bfqq) &&
> > +	if (bfq_may_expire_for_budget_timeout(bfqq) &&
> > 	    !bfq_bfqq_must_idle(bfqq))
> > 		goto expire;
> > 
> > @@ -5706,7 +5706,7 @@ static void bfq_completed_request(struct bfq_queue *bfqq, struct bfq_data *bfqd)
> > 			 * of its reserved service guarantees.
> > 			 */
> > 			return;
> > -		} else if (bfq_may_expire_for_budg_timeout(bfqq))
> > +		} else if (bfq_may_expire_for_budget_timeout(bfqq))
> > 			bfq_bfqq_expire(bfqd, bfqq, false,
> > 					BFQQE_BUDGET_TIMEOUT);
> > 		else if (RB_EMPTY_ROOT(&bfqq->sort_list) &&
> > -- 
> > 1.8.3.1
> > 
> 

Was this sent to some mailing list? I don't see an original email with
this patch.

-- 
  Oleksandr Natalenko (post-factum)