linux-kernel - RE: linux-next: manual merge of the rdma tree with Linus' tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 10 Feb 2021 18:57:24 +0000
From:   "Pearson, Robert B" <robert.pearson2@....com>
To:     Stephen Rothwell <sfr@...b.auug.org.au>,
        Doug Ledford <dledford@...hat.com>,
        Jason Gunthorpe <jgg@...lanox.com>
CC:     Bob Pearson <rpearsonhpe@...il.com>,
        Jason Gunthorpe <jgg@...dia.com>,
        Jason Gunthorpe <jgg@...pe.ca>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux Next Mailing List <linux-next@...r.kernel.org>,
        Martin Wilck <mwilck@...e.com>
Subject: RE: linux-next: manual merge of the rdma tree with Linus' tree

It looks like f1b0a8ea9f12 ("Revert "RDMA/rxe: Remove VLAN code leftovers from RXE"") has not been applied to rdma for-next which is where I do my work. Not sure how it got upstream.

bob

-----Original Message-----
From: Stephen Rothwell <sfr@...b.auug.org.au> 
Sent: Tuesday, February 9, 2021 8:16 PM
To: Doug Ledford <dledford@...hat.com>; Jason Gunthorpe <jgg@...lanox.com>
Cc: Pearson, Robert B <robert.pearson2@....com>; Bob Pearson <rpearsonhpe@...il.com>; Jason Gunthorpe <jgg@...dia.com>; Jason Gunthorpe <jgg@...pe.ca>; Linux Kernel Mailing List <linux-kernel@...r.kernel.org>; Linux Next Mailing List <linux-next@...r.kernel.org>; Martin Wilck <mwilck@...e.com>
Subject: linux-next: manual merge of the rdma tree with Linus' tree

Hi all,

Today's linux-next merge of the rdma tree got a conflict in:

  drivers/infiniband/sw/rxe/rxe_net.c

between commit:

  f1b0a8ea9f12 ("Revert "RDMA/rxe: Remove VLAN code leftovers from RXE"")

from Linus' tree and commit:

  899aba891cab ("RDMA/rxe: Fix FIXME in rxe_udp_encap_recv()")

from the rdma tree.

I fixed it up (see below) and can carry the fix as necessary. This is now fixed as far as linux-next is concerned, but any non trivial conflicts should be mentioned to your upstream maintainer when your tree is submitted for merging.  You may also want to consider cooperating with the maintainer of the conflicting tree to minimise any particularly complex conflicts.

--
Cheers,
Stephen Rothwell

diff --cc drivers/infiniband/sw/rxe/rxe_net.c
index 943914c2a50c,36d56163afac..000000000000
--- a/drivers/infiniband/sw/rxe/rxe_net.c
+++ b/drivers/infiniband/sw/rxe/rxe_net.c
@@@ -153,15 -152,14 +153,19 @@@ static struct dst_entry *rxe_find_route
  static int rxe_udp_encap_recv(struct sock *sk, struct sk_buff *skb)
  {
  	struct udphdr *udph;
+ 	struct rxe_dev *rxe;
  	struct net_device *ndev = skb->dev;
 +	struct net_device *rdev = ndev;
- 	struct rxe_dev *rxe = rxe_get_dev_from_net(ndev);
  	struct rxe_pkt_info *pkt = SKB_TO_PKT(skb);
  
+ 	/* takes a reference on rxe->ib_dev
+ 	 * drop when skb is freed
+ 	 */
+ 	rxe = rxe_get_dev_from_net(ndev);
 +	if (!rxe && is_vlan_dev(rdev)) {
 +		rdev = vlan_dev_real_dev(ndev);
 +		rxe = rxe_get_dev_from_net(rdev);
 +	}
  	if (!rxe)
  		goto drop;