linux-kernel - Re: [PATCH][next] io_uring: remove redundant initialization of variable ret

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BYAPR04MB4965CDA76126E201ACEA6BB6868D9@BYAPR04MB4965.namprd04.prod.outlook.com>
Date:   Wed, 10 Feb 2021 20:05:34 +0000
From:   Chaitanya Kulkarni <Chaitanya.Kulkarni@....com>
To:     Colin King <colin.king@...onical.com>,
        Jens Axboe <axboe@...nel.dk>,
        Pavel Begunkov <asml.silence@...il.com>,
        "io-uring@...r.kernel.org" <io-uring@...r.kernel.org>
CC:     "kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH][next] io_uring: remove redundant initialization of
 variable ret

On 2/10/21 12:02, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
>
> The variable ret is being initialized with a value that is never read
> and it is being updated later with a new value.  The initialization is
> redundant and can be removed.
>
> Addresses-Coverity: ("Unused value")
> Fixes: b63534c41e20 ("io_uring: re-issue block requests that failed because of resources")
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
Looks good.

Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@....com>