linux-kernel - Re: [PATCH] xfs: fix boolreturn.cocci warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 10 Feb 2021 22:25:08 +0000
From:   Chaitanya Kulkarni <Chaitanya.Kulkarni@....com>
To:     kernel test robot <lkp@...el.com>,
        Brian Foster <bfoster@...hat.com>
CC:     "kbuild-all@...ts.01.org" <kbuild-all@...ts.01.org>,
        "Darrick J. Wong" <darrick.wong@...cle.com>,
        "Darrick J. Wong" <djwong@...nel.org>,
        Allison Henderson <allison.henderson@...cle.com>,
        Christoph Hellwig <hch@....de>,
        "linux-xfs@...r.kernel.org" <linux-xfs@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] xfs: fix boolreturn.cocci warnings

On 2/10/21 12:11 PM, kernel test robot wrote:
> From: kernel test robot <lkp@...el.com>
>
> fs/xfs/xfs_log.c:1062:9-10: WARNING: return of 0/1 in function 'xfs_log_need_covered' with return type bool
>
>  Return statements in functions returning bool should use
>  true/false instead of 1/0.
> Generated by: scripts/coccinelle/misc/boolreturn.cocci
>
> Fixes: 37444fc4cc39 ("xfs: lift writable fs check up into log worker task")
> CC: Brian Foster <bfoster@...hat.com>
> Reported-by: kernel test robot <lkp@...el.com>
> Signed-off-by: kernel test robot <lkp@...el.com>
> ---
>
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/djwong/xfs-linux.git xfs-5.12-merge
> head:   560ab6c0d12ebccabb83638abe23a7875b946f9a
> commit: 37444fc4cc398266fe0f71a9c0925620d44fb76a [25/36] xfs: lift writable fs check up into log worker task
Looks good.

Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@....com>