linux-kernel - Re: [PATCH] ASoC: soc-pcm: change error message to debug message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a3cac294-4562-3042-7118-f013d6e4300b@linux.intel.com>
Date:   Tue, 9 Feb 2021 17:05:16 -0600
From:   Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>
To:     Mark Brown <broonie@...nel.org>
Cc:     Shengjiu Wang <shengjiu.wang@....com>, lgirdwood@...il.com,
        perex@...ex.cz, tiwai@...e.com, alsa-devel@...a-project.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ASoC: soc-pcm: change error message to debug message



On 2/9/21 4:23 PM, Mark Brown wrote:
> On Mon, Feb 08, 2021 at 09:06:44AM -0600, Pierre-Louis Bossart wrote:
> 
>> If you demote this to dev_dbg, we'll have to ask every single user who
>> reports 'sound is broken' to enable dynamic debug traces. I really don't see
>> the benefit, this is a clear case of 'fail big and fail early', partly
>> concealing the problem doesn't make it go away but harder to diagnose.
> 
> Don't you also get the same information out of the DAPM debugfs or did
> I misread where the error is generated from?

I re-checked and I will back-pedal on my comment. I confused this error 
message with the classic "ASoC: no backend DAIs enabled for %s".

I didn't find a single occurrence of this "ASoC: no BE found for %s" in 
any bug report or Google search.

Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>