linux-kernel - Re: [PATCH] clk: at91: Fix the declaration of the clocks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <161291858241.418021.7620663458602138308@swboyd.mtv.corp.google.com>
Date:   Tue, 09 Feb 2021 16:56:22 -0800
From:   Stephen Boyd <sboyd@...nel.org>
To:     Tudor Ambarus <tudor.ambarus@...rochip.com>,
        alexandre.belloni@...tlin.com, geert@...ux-m68k.org,
        gregkh@...uxfoundation.org, ludovic.desroches@...rochip.com,
        mturquette@...libre.com, nicolas.ferre@...rochip.com,
        saravanak@...gle.com
Cc:     mirq-linux@...e.qmqm.pl, claudiu.beznea@...rochip.com,
        a.fatoum@...gutronix.de, krzk@...nel.org,
        codrin.ciubotariu@...rochip.com, linux-clk@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        Tudor Ambarus <tudor.ambarus@...rochip.com>
Subject: Re: [PATCH] clk: at91: Fix the declaration of the clocks

Quoting Tudor Ambarus (2021-02-03 07:43:32)
> These are all "early clocks" that require initialization just at
> of_clk_init() time. Use CLK_OF_DECLARE() to declare them.
> 
> This also fixes a problem that was spotted when fw_devlink was
> set to 'on' by default: the boards failed to boot. The reason is
> that CLK_OF_DECLARE_DRIVER() clears the OF_POPULATED and causes
> the consumers of the clock to be postponed by fw_devlink until
> the second initialization routine of the clock has been completed.
> One of the consumers of the clock is the timer, which is used as a
> clocksource, and needs the clock initialized early. Postponing the
> timers caused the fail at boot.
> 
> Signed-off-by: Tudor Ambarus <tudor.ambarus@...rochip.com>
> ---

Applied to clk-next