linux-kernel - Re: [PATCH 00/20] Rid W=1 warnings in Crypto

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 10 Feb 2021 17:51:51 +1100
From:   Herbert Xu <herbert@...dor.apana.org.au>
To:     Lee Jones <lee.jones@...aro.org>
Cc:     linux-kernel@...r.kernel.org,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Andreas Westin <andreas.westin@...ricsson.com>,
        Atul Gupta <atul.gupta@...lsio.com>,
        Aymen Sghaier <aymen.sghaier@....com>,
        Ayush Sawal <ayush.sawal@...lsio.com>,
        Benjamin Herrenschmidt <benh@...nel.crashing.org>,
        Berne Hebark <berne.herbark@...ricsson.com>,
        Breno Leitão <leitao@...ian.org>,
        Daniele Alessandrelli <daniele.alessandrelli@...el.com>,
        "David S. Miller" <davem@...emloft.net>,
        Declan Murphy <declan.murphy@...el.com>,
        "Gustavo A. R. Silva" <gustavoars@...nel.org>,
        Harsh Jain <harsh@...lsio.com>,
        Henrique Cerri <mhcerri@...ibm.com>,
        Horia Geantă <horia.geanta@....com>,
        Jitendra Lulla <jlulla@...lsio.com>,
        Joakim Bech <joakim.xx.bech@...ricsson.com>,
        Jonas Linde <jonas.linde@...ricsson.com>,
        Jonathan Cameron <jonathan.cameron@...wei.com>,
        Kent Yoder <yoder1@...ibm.com>,
        linux-arm-kernel@...ts.infradead.org, linux-crypto@...r.kernel.org,
        linuxppc-dev@...ts.ozlabs.org,
        Ludovic Desroches <ludovic.desroches@...rochip.com>,
        Manoj Malviya <manojmalviya@...lsio.com>,
        Michael Ellerman <mpe@...erman.id.au>,
        M R Gowda <yeshaswi@...lsio.com>,
        Nayna Jain <nayna@...ux.ibm.com>,
        Nicolas Ferre <nicolas.ferre@...rochip.com>,
        Niklas Hernaeus <niklas.hernaeus@...ricsson.com>,
        Paul Mackerras <paulus@...ba.org>,
        Paulo Flabiano Smorigo <pfsmorigo@...il.com>,
        Rob Rice <rob.rice@...adcom.com>,
        Rohit Maheshwari <rohitm@...lsio.com>,
        Shujuan Chen <shujuan.chen@...ricsson.com>,
        Takashi Iwai <tiwai@...e.de>,
        Tudor Ambarus <tudor.ambarus@...rochip.com>,
        Vinay Kumar Yadav <vinay.yadav@...lsio.com>,
        Zaibo Xu <xuzaibo@...wei.com>
Subject: Re: [PATCH 00/20] Rid W=1 warnings in Crypto

On Thu, Feb 04, 2021 at 11:09:40AM +0000, Lee Jones wrote:
> This set is part of a larger effort attempting to clean-up W=1
> kernel builds, which are currently overwhelmingly riddled with
> niggly little warnings.
> 
> This is set 1 of 2 sets required to fully clean Crypto.
> 
> Lee Jones (20):
>   crypto: hisilicon: sec_drv: Supply missing description for
>     'sec_queue_empty()'s 'queue' param
>   crypto: bcm: util: Repair a couple of documentation formatting issues
>   crypto: chelsio: chcr_core: File headers are not good candidates for
>     kernel-doc
>   crypto: ux500: hash: hash_core: Fix worthy kernel-doc headers and
>     remove others
>   crypto: bcm: spu: Fix formatting and misspelling issues
>   crypto: keembay: ocs-hcu: Fix incorrectly named functions/structs
>   crypto: bcm: spu2: Fix a whole host of kernel-doc misdemeanours
>   crypto: ux500: cryp: Demote some conformant non-kernel headers fix
>     another
>   crypto: ux500: cryp_irq: File headers are not good kernel-doc
>     candidates
>   crypto: chelsio: chcr_algo: Fix a couple of kernel-doc issues caused
>     by doc-rot
>   crypto: ux500: cryp_core: Fix formatting issue and add description for
>     'session_id'
>   crypto: atmel-ecc: Struct headers need to start with keyword 'struct'
>   crypto: bcm: cipher: Provide description for 'req' and fix formatting
>     issues
>   crypto: caam: caampkc: Provide the name of the function
>   crypto: caam: caamalg_qi2: Supply a couple of 'fallback' related
>     descriptions
>   crypto: vmx: Source headers are not good kernel-doc candidates
>   crypto: nx: nx-aes-cbc: Headers comments should not be kernel-doc
>   crypto: nx: nx_debugfs: Header comments should not be kernel-doc
>   crypto: nx: Demote header comment and add description for 'nbytes'
>   crypto: cavium: nitrox_isr: Demote non-compliant kernel-doc headers

Thanks for doing this.  But please don't split the patches at the
file level.  Instead split them at the driver level.  For example,
all of your bcm changes should be one patch.
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt