linux-kernel - Re: [PATCH] crypto: ecdh_helper - Ensure 'len >= secret.len' in decode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210210072242.GF4493@gondor.apana.org.au>
Date:   Wed, 10 Feb 2021 18:22:42 +1100
From:   Herbert Xu <herbert@...dor.apana.org.au>
To:     Daniele Alessandrelli <daniele.alessandrelli@...ux.intel.com>
Cc:     daniele.alessandrelli@...el.com, linux-crypto@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] crypto: ecdh_helper - Ensure 'len >= secret.len' in
 decode_key()

On Wed, Feb 03, 2021 at 11:28:37AM +0000, Daniele Alessandrelli wrote:
> From: Daniele Alessandrelli <daniele.alessandrelli@...el.com>
> 
> The length ('len' parameter) passed to crypto_ecdh_decode_key() is never
> checked against the length encoded in the passed buffer ('buf'
> parameter). This could lead to an out-of-bounds access when the passed
> length is less than the encoded length.
> 
> Add a check to prevent that.
> 
> Signed-off-by: Daniele Alessandrelli <daniele.alessandrelli@...el.com>
> ---
>  crypto/ecdh_helper.c | 3 +++
>  1 file changed, 3 insertions(+)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt