linux-kernel - Re: [PATCH v2 1/2] pinctrl: use to octal permissions for debugfs files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75Vf7HD-YwksrcUeqXqgOSCH08RywT1WgRBj48Hu4GvGtZQ@mail.gmail.com>
Date:   Wed, 10 Feb 2021 12:14:46 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:     Drew Fustini <drew@...gleboard.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Tony Lindgren <tony@...mide.com>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Pantelis Antoniou <pantelis.antoniou@...sulko.com>,
        Jason Kridner <jkridner@...gleboard.org>,
        Robert Nelson <robertcnelson@...gleboard.org>
Subject: Re: [PATCH v2 1/2] pinctrl: use to octal permissions for debugfs files

On Wed, Feb 10, 2021 at 10:31 AM Geert Uytterhoeven
<geert@...ux-m68k.org> wrote:
> On Wed, Feb 10, 2021 at 8:50 AM Drew Fustini <drew@...gleboard.org> wrote:

...

> > -       debugfs_create_file("pinctrl-devices", S_IFREG | S_IRUGO,
> > +       debugfs_create_file("pinctrl-devices", 0400,
>
> What about the loss of S_IFREG?

What do you mean?
https://elixir.bootlin.com/linux/latest/source/fs/debugfs/inode.c#L387

-- 
With Best Regards,
Andy Shevchenko