linux-kernel - Re: [PATCH] module: potential uninitialized return in module_kallsyms_on_each

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LSU.2.21.2102101307030.14803@pobox.suse.cz>
Date:   Wed, 10 Feb 2021 13:08:39 +0100 (CET)
From:   Miroslav Benes <mbenes@...e.cz>
To:     Dan Carpenter <dan.carpenter@...cle.com>
cc:     Jessica Yu <jeyu@...nel.org>, Christoph Hellwig <hch@....de>,
        Petr Mladek <pmladek@...e.com>, linux-kernel@...r.kernel.org,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] module: potential uninitialized return in
 module_kallsyms_on_each_symbol()

On Wed, 10 Feb 2021, Dan Carpenter wrote:

> Smatch complains that:
> 
> 	kernel/module.c:4472 module_kallsyms_on_each_symbol()
>         error: uninitialized symbol 'ret'.
> 
> This warning looks like it could be correct if the &modules list is
> empty.
> 
> Fixes: 013c1667cf78 ("kallsyms: refactor {,module_}kallsyms_on_each_symbol")
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>

Reviewed-by: Miroslav Benes <mbenes@...e.cz>

M