lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Fri, 12 Feb 2021 03:56:36 +0800
From:   kernel test robot <lkp@...el.com>
To:     Sascha Hauer <s.hauer@...gutronix.de>,
        linux-fsdevel@...r.kernel.org
Cc:     kbuild-all@...ts.01.org, clang-built-linux@...glegroups.com,
        linux-kernel@...r.kernel.org,
        Christoph Hellwig <hch@...radead.org>, kernel@...gutronix.de,
        Jan Kara <jack@...e.com>, Richard Weinberger <richard@....at>,
        Sascha Hauer <s.hauer@...gutronix.de>
Subject: Re: [PATCH 2/2] quota: wire up quotactl_path

Hi Sascha,

I love your patch! Perhaps something to improve:

[auto build test WARNING on arm64/for-next/core]
[also build test WARNING on tip/x86/asm m68k/for-next hp-parisc/for-next powerpc/next s390/features linus/master v5.11-rc7]
[cannot apply to sparc-next/master sparc/master xtensa/for_next next-20210211]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Sascha-Hauer/quota-Add-mountpath-based-quota-support/20210211-233912
base:   https://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-next/core
config: x86_64-randconfig-a013-20210209 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project c9439ca36342fb6013187d0a69aef92736951476)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install x86_64 cross compiling tool for clang build
        # apt-get install binutils-x86-64-linux-gnu
        # https://github.com/0day-ci/linux/commit/0fa8489f958d6ec34215930a8d1a2d4b6644fea3
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Sascha-Hauer/quota-Add-mountpath-based-quota-support/20210211-233912
        git checkout 0fa8489f958d6ec34215930a8d1a2d4b6644fea3
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   In file included from arch/x86/entry/syscall_32.c:13:
   ./arch/x86/include/generated/asm/syscalls_32.h:830:18: error: expected parameter declarator
   __SYSCALL_COMMON(442, sys_quotactl_path)
                    ^
   ./arch/x86/include/generated/asm/syscalls_32.h:830:18: error: expected ')'
   ./arch/x86/include/generated/asm/syscalls_32.h:830:17: note: to match this '('
   __SYSCALL_COMMON(442, sys_quotactl_path)
                   ^
>> ./arch/x86/include/generated/asm/syscalls_32.h:830:1: warning: declaration specifier missing, defaulting to 'int'
   __SYSCALL_COMMON(442, sys_quotactl_path)
   ^
   int
   ./arch/x86/include/generated/asm/syscalls_32.h:830:17: error: this function declaration is not a prototype [-Werror,-Wstrict-prototypes]
   __SYSCALL_COMMON(442, sys_quotactl_path)
                   ^
                                          void
   ./arch/x86/include/generated/asm/syscalls_32.h:830:41: error: expected ';' after top level declarator
   __SYSCALL_COMMON(442, sys_quotactl_path)
                                           ^
                                           ;
   In file included from arch/x86/entry/syscall_32.c:24:
   ./arch/x86/include/generated/asm/syscalls_32.h:830:23: error: use of undeclared identifier 'sys_quotactl_path'
   __SYSCALL_COMMON(442, sys_quotactl_path)
                         ^
   1 warning and 5 errors generated.
--
   kernel/sys_ni.c:88:1: warning: no previous prototype for function '__x64_sys_flock' [-Wmissing-prototypes]
   COND_SYSCALL(flock);
   ^
   arch/x86/include/asm/syscall_wrapper.h:256:2: note: expanded from macro 'COND_SYSCALL'
           __X64_COND_SYSCALL(name)                                        \
           ^
   arch/x86/include/asm/syscall_wrapper.h:100:2: note: expanded from macro '__X64_COND_SYSCALL'
           __COND_SYSCALL(x64, sys_##name)
           ^
   arch/x86/include/asm/syscall_wrapper.h:83:14: note: expanded from macro '__COND_SYSCALL'
           __weak long __##abi##_##name(const struct pt_regs *__unused)    \
                       ^
   <scratch space>:225:1: note: expanded from here
   __x64_sys_flock
   ^
   kernel/sys_ni.c:88:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   arch/x86/include/asm/syscall_wrapper.h:256:2: note: expanded from macro 'COND_SYSCALL'
           __X64_COND_SYSCALL(name)                                        \
           ^
   arch/x86/include/asm/syscall_wrapper.h:100:2: note: expanded from macro '__X64_COND_SYSCALL'
           __COND_SYSCALL(x64, sys_##name)
           ^
   arch/x86/include/asm/syscall_wrapper.h:83:9: note: expanded from macro '__COND_SYSCALL'
           __weak long __##abi##_##name(const struct pt_regs *__unused)    \
                  ^
   kernel/sys_ni.c:88:1: warning: no previous prototype for function '__ia32_sys_flock' [-Wmissing-prototypes]
   COND_SYSCALL(flock);
   ^
   arch/x86/include/asm/syscall_wrapper.h:257:2: note: expanded from macro 'COND_SYSCALL'
           __IA32_COND_SYSCALL(name)
           ^
   arch/x86/include/asm/syscall_wrapper.h:120:2: note: expanded from macro '__IA32_COND_SYSCALL'
           __COND_SYSCALL(ia32, sys_##name)
           ^
   arch/x86/include/asm/syscall_wrapper.h:83:14: note: expanded from macro '__COND_SYSCALL'
           __weak long __##abi##_##name(const struct pt_regs *__unused)    \
                       ^
   <scratch space>:229:1: note: expanded from here
   __ia32_sys_flock
   ^
   kernel/sys_ni.c:88:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   arch/x86/include/asm/syscall_wrapper.h:257:2: note: expanded from macro 'COND_SYSCALL'
           __IA32_COND_SYSCALL(name)
           ^
   arch/x86/include/asm/syscall_wrapper.h:120:2: note: expanded from macro '__IA32_COND_SYSCALL'
           __COND_SYSCALL(ia32, sys_##name)
           ^
   arch/x86/include/asm/syscall_wrapper.h:83:9: note: expanded from macro '__COND_SYSCALL'
           __weak long __##abi##_##name(const struct pt_regs *__unused)    \
                  ^
   kernel/sys_ni.c:101:1: warning: no previous prototype for function '__x64_sys_quotactl' [-Wmissing-prototypes]
   COND_SYSCALL(quotactl);
   ^
   arch/x86/include/asm/syscall_wrapper.h:256:2: note: expanded from macro 'COND_SYSCALL'
           __X64_COND_SYSCALL(name)                                        \
           ^
   arch/x86/include/asm/syscall_wrapper.h:100:2: note: expanded from macro '__X64_COND_SYSCALL'
           __COND_SYSCALL(x64, sys_##name)
           ^
   arch/x86/include/asm/syscall_wrapper.h:83:14: note: expanded from macro '__COND_SYSCALL'
           __weak long __##abi##_##name(const struct pt_regs *__unused)    \
                       ^
   <scratch space>:233:1: note: expanded from here
   __x64_sys_quotactl
   ^
   kernel/sys_ni.c:101:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   arch/x86/include/asm/syscall_wrapper.h:256:2: note: expanded from macro 'COND_SYSCALL'
           __X64_COND_SYSCALL(name)                                        \
           ^
   arch/x86/include/asm/syscall_wrapper.h:100:2: note: expanded from macro '__X64_COND_SYSCALL'
           __COND_SYSCALL(x64, sys_##name)
           ^
   arch/x86/include/asm/syscall_wrapper.h:83:9: note: expanded from macro '__COND_SYSCALL'
           __weak long __##abi##_##name(const struct pt_regs *__unused)    \
                  ^
   kernel/sys_ni.c:101:1: warning: no previous prototype for function '__ia32_sys_quotactl' [-Wmissing-prototypes]
   COND_SYSCALL(quotactl);
   ^
   arch/x86/include/asm/syscall_wrapper.h:257:2: note: expanded from macro 'COND_SYSCALL'
           __IA32_COND_SYSCALL(name)
           ^
   arch/x86/include/asm/syscall_wrapper.h:120:2: note: expanded from macro '__IA32_COND_SYSCALL'
           __COND_SYSCALL(ia32, sys_##name)
           ^
   arch/x86/include/asm/syscall_wrapper.h:83:14: note: expanded from macro '__COND_SYSCALL'
           __weak long __##abi##_##name(const struct pt_regs *__unused)    \
                       ^
   <scratch space>:237:1: note: expanded from here
   __ia32_sys_quotactl
   ^
   kernel/sys_ni.c:101:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   arch/x86/include/asm/syscall_wrapper.h:257:2: note: expanded from macro 'COND_SYSCALL'
           __IA32_COND_SYSCALL(name)
           ^
   arch/x86/include/asm/syscall_wrapper.h:120:2: note: expanded from macro '__IA32_COND_SYSCALL'
           __COND_SYSCALL(ia32, sys_##name)
           ^
   arch/x86/include/asm/syscall_wrapper.h:83:9: note: expanded from macro '__COND_SYSCALL'
           __weak long __##abi##_##name(const struct pt_regs *__unused)    \
                  ^
>> kernel/sys_ni.c:102:1: warning: no previous prototype for function '__x64_sys_quotactl_path' [-Wmissing-prototypes]
   COND_SYSCALL(quotactl_path);
   ^
   arch/x86/include/asm/syscall_wrapper.h:256:2: note: expanded from macro 'COND_SYSCALL'
           __X64_COND_SYSCALL(name)                                        \
           ^
   arch/x86/include/asm/syscall_wrapper.h:100:2: note: expanded from macro '__X64_COND_SYSCALL'
           __COND_SYSCALL(x64, sys_##name)
           ^
   arch/x86/include/asm/syscall_wrapper.h:83:14: note: expanded from macro '__COND_SYSCALL'
           __weak long __##abi##_##name(const struct pt_regs *__unused)    \
                       ^
   <scratch space>:241:1: note: expanded from here
   __x64_sys_quotactl_path
   ^
   kernel/sys_ni.c:102:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   arch/x86/include/asm/syscall_wrapper.h:256:2: note: expanded from macro 'COND_SYSCALL'
           __X64_COND_SYSCALL(name)                                        \
           ^
   arch/x86/include/asm/syscall_wrapper.h:100:2: note: expanded from macro '__X64_COND_SYSCALL'
           __COND_SYSCALL(x64, sys_##name)
           ^
   arch/x86/include/asm/syscall_wrapper.h:83:9: note: expanded from macro '__COND_SYSCALL'
           __weak long __##abi##_##name(const struct pt_regs *__unused)    \
                  ^
>> kernel/sys_ni.c:102:1: warning: no previous prototype for function '__ia32_sys_quotactl_path' [-Wmissing-prototypes]
   COND_SYSCALL(quotactl_path);
   ^
   arch/x86/include/asm/syscall_wrapper.h:257:2: note: expanded from macro 'COND_SYSCALL'
           __IA32_COND_SYSCALL(name)
           ^
   arch/x86/include/asm/syscall_wrapper.h:120:2: note: expanded from macro '__IA32_COND_SYSCALL'
           __COND_SYSCALL(ia32, sys_##name)
           ^
   arch/x86/include/asm/syscall_wrapper.h:83:14: note: expanded from macro '__COND_SYSCALL'
           __weak long __##abi##_##name(const struct pt_regs *__unused)    \
                       ^
   <scratch space>:245:1: note: expanded from here
   __ia32_sys_quotactl_path
   ^
   kernel/sys_ni.c:102:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   arch/x86/include/asm/syscall_wrapper.h:257:2: note: expanded from macro 'COND_SYSCALL'
           __IA32_COND_SYSCALL(name)
           ^
   arch/x86/include/asm/syscall_wrapper.h:120:2: note: expanded from macro '__IA32_COND_SYSCALL'
           __COND_SYSCALL(ia32, sys_##name)
           ^
   arch/x86/include/asm/syscall_wrapper.h:83:9: note: expanded from macro '__COND_SYSCALL'
           __weak long __##abi##_##name(const struct pt_regs *__unused)    \
                  ^
   kernel/sys_ni.c:113:1: warning: no previous prototype for function '__x64_sys_signalfd4' [-Wmissing-prototypes]
   COND_SYSCALL(signalfd4);
   ^
   arch/x86/include/asm/syscall_wrapper.h:256:2: note: expanded from macro 'COND_SYSCALL'
           __X64_COND_SYSCALL(name)                                        \
           ^
   arch/x86/include/asm/syscall_wrapper.h:100:2: note: expanded from macro '__X64_COND_SYSCALL'
           __COND_SYSCALL(x64, sys_##name)
           ^
   arch/x86/include/asm/syscall_wrapper.h:83:14: note: expanded from macro '__COND_SYSCALL'
           __weak long __##abi##_##name(const struct pt_regs *__unused)    \
                       ^
   <scratch space>:249:1: note: expanded from here
   __x64_sys_signalfd4
   ^
   kernel/sys_ni.c:113:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   arch/x86/include/asm/syscall_wrapper.h:256:2: note: expanded from macro 'COND_SYSCALL'
           __X64_COND_SYSCALL(name)                                        \
           ^
   arch/x86/include/asm/syscall_wrapper.h:100:2: note: expanded from macro '__X64_COND_SYSCALL'
           __COND_SYSCALL(x64, sys_##name)
           ^
   arch/x86/include/asm/syscall_wrapper.h:83:9: note: expanded from macro '__COND_SYSCALL'
           __weak long __##abi##_##name(const struct pt_regs *__unused)    \
                  ^
   kernel/sys_ni.c:113:1: warning: no previous prototype for function '__ia32_sys_signalfd4' [-Wmissing-prototypes]
   COND_SYSCALL(signalfd4);
   ^
   arch/x86/include/asm/syscall_wrapper.h:257:2: note: expanded from macro 'COND_SYSCALL'
           __IA32_COND_SYSCALL(name)
           ^
   arch/x86/include/asm/syscall_wrapper.h:120:2: note: expanded from macro '__IA32_COND_SYSCALL'
           __COND_SYSCALL(ia32, sys_##name)
           ^
   arch/x86/include/asm/syscall_wrapper.h:83:14: note: expanded from macro '__COND_SYSCALL'
           __weak long __##abi##_##name(const struct pt_regs *__unused)    \
                       ^
   <scratch space>:253:1: note: expanded from here
   __ia32_sys_signalfd4
   ^
   kernel/sys_ni.c:113:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   arch/x86/include/asm/syscall_wrapper.h:257:2: note: expanded from macro 'COND_SYSCALL'
           __IA32_COND_SYSCALL(name)
           ^
   arch/x86/include/asm/syscall_wrapper.h:120:2: note: expanded from macro '__IA32_COND_SYSCALL'
           __COND_SYSCALL(ia32, sys_##name)
           ^
   arch/x86/include/asm/syscall_wrapper.h:83:9: note: expanded from macro '__COND_SYSCALL'
           __weak long __##abi##_##name(const struct pt_regs *__unused)    \
                  ^
   kernel/sys_ni.c:114:1: warning: no previous prototype for function '__ia32_compat_sys_signalfd4' [-Wmissing-prototypes]
   COND_SYSCALL_COMPAT(signalfd4);
   ^
   arch/x86/include/asm/syscall_wrapper.h:218:2: note: expanded from macro 'COND_SYSCALL_COMPAT'
           __IA32_COMPAT_COND_SYSCALL(name)                                \
           ^
   arch/x86/include/asm/syscall_wrapper.h:148:2: note: expanded from macro '__IA32_COMPAT_COND_SYSCALL'
           __COND_SYSCALL(ia32, compat_sys_##name)
           ^
   arch/x86/include/asm/syscall_wrapper.h:83:14: note: expanded from macro '__COND_SYSCALL'
           __weak long __##abi##_##name(const struct pt_regs *__unused)    \
                       ^
   <scratch space>:257:1: note: expanded from here
   __ia32_compat_sys_signalfd4
   ^
   kernel/sys_ni.c:114:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   arch/x86/include/asm/syscall_wrapper.h:218:2: note: expanded from macro 'COND_SYSCALL_COMPAT'
           __IA32_COMPAT_COND_SYSCALL(name)                                \
           ^
   arch/x86/include/asm/syscall_wrapper.h:148:2: note: expanded from macro '__IA32_COMPAT_COND_SYSCALL'
           __COND_SYSCALL(ia32, compat_sys_##name)
           ^
   arch/x86/include/asm/syscall_wrapper.h:83:9: note: expanded from macro '__COND_SYSCALL'
           __weak long __##abi##_##name(const struct pt_regs *__unused)    \
                  ^
   kernel/sys_ni.c:123:1: warning: no previous prototype for function '__x64_sys_timerfd_create' [-Wmissing-prototypes]


vim +/__x64_sys_quotactl_path +102 kernel/sys_ni.c

    99	
   100	/* fs/quota.c */
   101	COND_SYSCALL(quotactl);
 > 102	COND_SYSCALL(quotactl_path);
   103	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (36960 bytes)

Powered by blists - more mailing lists