linux-kernel - Re: [PATCH] staging: vt6656: Fixed issue with alignment in rf.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a94be58e-b503-1fcf-7c5c-158ce7e2d188@icloud.com>
Date:   Fri, 12 Feb 2021 02:32:51 +0530
From:   Pritthijit Nath <pritthijit.nath@...oud.com>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     tvboxspy@...il.com, devel@...verdev.osuosl.org,
        oscar.carter@....com, forest@...ttletooquiet.net,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: vt6656: Fixed issue with alignment in rf.c

On 12/02/21 2:14 am, Greg KH wrote:
> On Fri, Feb 12, 2021 at 02:07:50AM +0530, Pritthijit Nath wrote:
>> On 12/02/21 1:59 am, Greg KH wrote:
>>> On Thu, Feb 11, 2021 at 08:54:26PM +0530, Pritthijit Nath wrote:
>>>> This change fixes a checkpatch CHECK style issue for "Alignment should match open parenthesis".
>>>>
>>>> Signed-off-by: Pritthijit Nath <pritthijit.nath@...oud.com>
>>>> ---
>>>>  drivers/staging/vt6656/rf.c | 2 +-
>>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/drivers/staging/vt6656/rf.c b/drivers/staging/vt6656/rf.c
>>>> index 5b8da06e3916..bcd4d467e03a 100644
>>>> --- a/drivers/staging/vt6656/rf.c
>>>> +++ b/drivers/staging/vt6656/rf.c
>>>> @@ -687,7 +687,7 @@ static int vnt_rf_set_txpower(struct vnt_private *priv, u8 power,
>>>>  
>>>>  			if (hw_value < ARRAY_SIZE(vt3226d0_lo_current_table)) {
>>>>  				ret = vnt_rf_write_embedded(priv,
>>>> -					vt3226d0_lo_current_table[hw_value]);
>>>> +							    vt3226d0_lo_current_table[hw_value]);
>>>>  				if (ret)
>>>>  					return ret;
>>>>  			}
>>>> -- 
>>>> 2.25.1
>>>
>>> Please run this change, with the changelog above, through
>>> checkpatch.pl, fix that, and resend.
>>>
>>> thanks,
>>>
>>> greg k-h
>>>
>>
>> This change fixes a checkpatch CHECK style issue for "Alignment should 
>> match open parenthesis".
>>
>> Signed-off-by: Pritthijit Nath <pritthijit.nath@...oud.com>
>> ---
>>  drivers/staging/vt6656/rf.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/staging/vt6656/rf.c b/drivers/staging/vt6656/rf.c
>> index 5b8da06e3916..bcd4d467e03a 100644
>> --- a/drivers/staging/vt6656/rf.c
>> +++ b/drivers/staging/vt6656/rf.c
>> @@ -687,7 +687,7 @@ static int vnt_rf_set_txpower(struct vnt_private *priv, u8 power,
>>  
>>  			if (hw_value < ARRAY_SIZE(vt3226d0_lo_current_table)) {
>>  				ret = vnt_rf_write_embedded(priv,
>> -					vt3226d0_lo_current_table[hw_value]);
>> +							    vt3226d0_lo_current_table[hw_value]);
>>  				if (ret)
>>  					return ret;
>>  			}
> 
> I can't take this type of submission, do you see other patches submitted
> this way on the mailing list?
Actually I am having a hard time since this one's my first. I would really appreciate if you could be a little clear. Should I resend the entire patch as a new thread?

> 
> Also, you have a trailing space in your changelog text :(

Thanks for pointing out. Yes, I have fixed the trailing space.

> 
> thanks,
> 
> greg k-h
>