linux-kernel - Re: [PATCH] erofs: initialized fields can only be observed after bit is set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <801d8f5d-9d5f-bc6a-1796-70d1038611da@kernel.org>
Date:   Thu, 11 Feb 2021 11:45:20 +0800
From:   Chao Yu <chao@...nel.org>
To:     Gao Xiang <hsiangkao@....com>, linux-erofs@...ts.ozlabs.org
Cc:     LKML <linux-kernel@...r.kernel.org>, stable@...r.kernel.org
Subject: Re: [PATCH] erofs: initialized fields can only be observed after bit
 is set

On 2021/2/9 21:06, Gao Xiang via Linux-erofs wrote:
> From: Gao Xiang <hsiangkao@...hat.com>
> 
> Currently, although set_bit() & test_bit() pairs are used as a fast-
> path for initialized configurations. However, these atomic ops are
> actually relaxed forms. Instead, load-acquire & store-release form is
> needed to make sure uninitialized fields won't be observed in advance
> here (yet no such corresponding bitops so use full barriers instead.)
> 
> Fixes: 62dc45979f3f ("staging: erofs: fix race of initializing xattrs of a inode at the same time")
> Fixes: 152a333a5895 ("staging: erofs: add compacted compression indexes support")
> Cc: <stable@...r.kernel.org> # 5.3+
> Reported-by: Huang Jianan <huangjianan@...o.com>
> Signed-off-by: Gao Xiang <hsiangkao@...hat.com>

Thanks for detailed explanation for barrier offline.

Reviewed-by: Chao Yu <yuchao0@...wei.com>

Thanks,