linux-kernel - Re: linux-next: Tree for Feb 10 (acrn)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2728d6d9-7cb0-c9a3-c5b8-cbc9858e4c10@infradead.org>
Date:   Wed, 10 Feb 2021 20:20:34 -0800
From:   Randy Dunlap <rdunlap@...radead.org>
To:     "Liu, Shuo A" <shuo.a.liu@...el.com>,
        Stephen Rothwell <sfr@...b.auug.org.au>,
        Linux Next Mailing List <linux-next@...r.kernel.org>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        acrn-dev@...ts.projectacrn.org
Subject: Re: linux-next: Tree for Feb 10 (acrn)

On 2/10/21 7:29 PM, Liu, Shuo A wrote:
> 
> 
> On 2/11/2021 01:52, Randy Dunlap wrote:
>> On 2/10/21 3:42 AM, Stephen Rothwell wrote:
>>> Hi all,
>>>
>>> Changes since 20210209:
>>>
>>
>> ../drivers/virt/acrn/hsm.c: In function ‘remove_cpu_store’:
>> ../drivers/virt/acrn/hsm.c:389:3: error: implicit declaration of function ‘remove_cpu’; did you mean ‘register_cpu’? [-Werror=implicit-function-declaration]
>>    remove_cpu(cpu);
>>
>> ../drivers/virt/acrn/hsm.c:402:2: error: implicit declaration of function ‘add_cpu’; did you mean ‘task_cpu’? [-Werror=implicit-function-declaration]
>>   add_cpu(cpu);
>>
>>
>> Full randconfig file is attached.
>>
> 
> Thanks.
> The vCPU removing depends on CONFIG_HOTPLUG_CPU. Below change could fix.

Yes, it does, thanks.

Acked-by: Randy Dunlap <rdunlap@...radead.org> # build-tested

> ---
> 
> diff --git a/drivers/virt/acrn/hsm.c b/drivers/virt/acrn/hsm.c
> index 1f6b7c54a1a4..e340788aacdf 100644
> --- a/drivers/virt/acrn/hsm.c
> +++ b/drivers/virt/acrn/hsm.c
> @@ -372,6 +372,7 @@ static int acrn_dev_release(struct inode *inode,
> struct file *filp)
>         return 0;
>  }
> 
> +#ifdef CONFIG_HOTPLUG_CPU
>  static ssize_t remove_cpu_store(struct device *dev,
>                                 struct device_attribute *attr,
>                                 const char *buf, size_t count)
> @@ -403,9 +404,12 @@ static ssize_t remove_cpu_store(struct device *dev,
>         return ret;
>  }
>  static DEVICE_ATTR_WO(remove_cpu);
> +#endif
> 
>  static struct attribute *acrn_attrs[] = {
> +#ifdef CONFIG_HOTPLUG_CPU
>         &dev_attr_remove_cpu.attr,
> +#endif
>         NULL
>  };
> 


-- 
~Randy