linux-kernel - Re: [PATCH] arm/xen: Don't probe xenbus as part of an early initcall

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <06a4feb3-a29e-221d-cdb6-68b9c453b2a4@suse.com>
Date:   Thu, 11 Feb 2021 07:55:42 +0100
From:   Jürgen Groß <jgross@...e.com>
To:     Julien Grall <julien@....org>, xen-devel@...ts.xenproject.org
Cc:     sstabellini@...nel.org, boris.ostrovsky@...cle.com,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        Julien Grall <jgrall@...zon.com>,
        Ian Jackson <iwj@...project.org>, dwmw@...zon.co.uk
Subject: Re: [PATCH] arm/xen: Don't probe xenbus as part of an early initcall

On 10.02.21 18:06, Julien Grall wrote:
> From: Julien Grall <jgrall@...zon.com>
> 
> After Commit 3499ba8198cad ("xen: Fix event channel callback via
> INTX/GSI"), xenbus_probe() will be called too early on Arm. This will
> recent to a guest hang during boot.
> 
> If there hang wasn't there, we would have ended up to call
> xenbus_probe() twice (the second time is in xenbus_probe_initcall()).
> 
> We don't need to initialize xenbus_probe() early for Arm guest.
> Therefore, the call in xen_guest_init() is now removed.
> 
> After this change, there is no more external caller for xenbus_probe().
> So the function is turned to a static one. Interestingly there were two
> prototypes for it.
> 
> Fixes: 3499ba8198cad ("xen: Fix event channel callback via INTX/GSI")
> Reported-by: Ian Jackson <iwj@...project.org>
> Signed-off-by: Julien Grall <jgrall@...zon.com>

Pushed to xen/tip.git for-linus-5.11


Juergen

Download attachment "OpenPGP_0xB0DE9DD628BF132F.asc" of type "application/pgp-keys" (3092 bytes)

Download attachment "OpenPGP_signature" of type "application/pgp-signature" (496 bytes)