linux-kernel - Re: [PATCH 8/9] vfio/pci: use x86 naming instead of igd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210211085021.GD2378134@infradead.org>
Date:   Thu, 11 Feb 2021 08:50:21 +0000
From:   Christoph Hellwig <hch@...radead.org>
To:     Max Gurtovoy <mgurtovoy@...dia.com>
Cc:     Alexey Kardashevskiy <aik@...abs.ru>,
        Cornelia Huck <cohuck@...hat.com>,
        Alex Williamson <alex.williamson@...hat.com>,
        Matthew Rosato <mjrosato@...ux.ibm.com>, jgg@...dia.com,
        kvm@...r.kernel.org, linux-kernel@...r.kernel.org,
        liranl@...dia.com, oren@...dia.com, tzahio@...dia.com,
        leonro@...dia.com, yarong@...dia.com, aviadye@...dia.com,
        shahafs@...dia.com, artemp@...dia.com, kwankhede@...dia.com,
        ACurrid@...dia.com, gmataev@...dia.com, cjia@...dia.com,
        yishaih@...dia.com
Subject: Re: [PATCH 8/9] vfio/pci: use x86 naming instead of igd

On Thu, Feb 04, 2021 at 11:12:49AM +0200, Max Gurtovoy wrote:
> But the PCI function (the bounded BDF) is GPU function or NVLINK function ?
> 
> If it's NVLINK function then we should fail probing in the host vfio-pci
> driver.
> 
> if its a GPU function so it shouldn't been called nvlink2 vfio-pci driver.
> Its just an extension in the GPU vfio-pci driver.

I suspect the trivial and correct answer is that we should just drop the
driver entirely.  It is for obsolete hardware that never had upstream
support for even using it in the guest.  It also is the reason for
keeping cruft in the always built-in powernv platform code alive that
is otherwise dead wood.