linux-kernel - Re: [PATCH 1/3] regulator: pca9450: Add SD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210211130406.GC5217@sirena.org.uk>
Date:   Thu, 11 Feb 2021 13:04:06 +0000
From:   Mark Brown <broonie@...nel.org>
To:     Schrempf Frieder <frieder.schrempf@...tron.de>
Cc:     Liam Girdwood <lgirdwood@...il.com>,
        Axel Lin <axel.lin@...ics.com>,
        Rikard Falkeborn <rikard.falkeborn@...il.com>,
        Robin Gong <yibin.gong@....com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] regulator: pca9450: Add SD_VSEL GPIO for LDO5

On Thu, Feb 11, 2021 at 11:55:28AM +0100, Schrempf Frieder wrote:

> +	if (IS_ERR(pca9450->sd_vsel_gpio)) {
> +		dev_err(&i2c->dev, "Failed to get SD_VSEL GPIO\n");

Not critical but it's generally better to display the error code when
logging an error to aid in diagnostics.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)