linux-kernel - RE: [PATCH v2 4/8] xen/netback: fix spurious event detection for common event case

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <001d01d70080$4a5446d0$defcd470$@xen.org>
Date:   Thu, 11 Feb 2021 14:15:02 -0000
From:   Paul Durrant <xadimgnik@...il.com>
To:     "'Juergen Gross'" <jgross@...e.com>,
        <xen-devel@...ts.xenproject.org>, <netdev@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Cc:     "'Wei Liu'" <wei.liu@...nel.org>,
        "'David S. Miller'" <davem@...emloft.net>,
        "'Jakub Kicinski'" <kuba@...nel.org>
Subject: RE: [PATCH v2 4/8] xen/netback: fix spurious event detection for common event case

> -----Original Message-----
> From: Juergen Gross <jgross@...e.com>
> Sent: 11 February 2021 10:16
> To: xen-devel@...ts.xenproject.org; netdev@...r.kernel.org; linux-kernel@...r.kernel.org
> Cc: Juergen Gross <jgross@...e.com>; Wei Liu <wei.liu@...nel.org>; Paul Durrant <paul@....org>; David
> S. Miller <davem@...emloft.net>; Jakub Kicinski <kuba@...nel.org>
> Subject: [PATCH v2 4/8] xen/netback: fix spurious event detection for common event case
> 
> In case of a common event for rx and tx queue the event should be
> regarded to be spurious if no rx and no tx requests are pending.
> 
> Unfortunately the condition for testing that is wrong causing to
> decide a event being spurious if no rx OR no tx requests are
> pending.
> 
> Fix that plus using local variables for rx/tx pending indicators in
> order to split function calls and if condition.
> 

Definitely neater.

> Fixes: 23025393dbeb3b ("xen/netback: use lateeoi irq binding")
> Signed-off-by: Juergen Gross <jgross@...e.com>

Reviewed-by: Paul Durrant <paul@....org>