linux-kernel - Re: [PATCH 1/2] quota: Add mountpath based quota support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210211153813.GA2480649@infradead.org>
Date:   Thu, 11 Feb 2021 15:38:13 +0000
From:   Christoph Hellwig <hch@...radead.org>
To:     Sascha Hauer <s.hauer@...gutronix.de>
Cc:     linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
        Christoph Hellwig <hch@...radead.org>, kernel@...gutronix.de,
        Jan Kara <jack@...e.com>, Richard Weinberger <richard@....at>
Subject: Re: [PATCH 1/2] quota: Add mountpath based quota support

> +	if (!mountpoint)
> +		return -ENODEV;
> +
> +	ret = user_path_at(AT_FDCWD, mountpoint,
> +			     LOOKUP_FOLLOW | LOOKUP_AUTOMOUNT, &mountpath);

user_path_at handles an empty path, although you'll get EFAULT instead.
Do we care about the -ENODEV here?

Otherwise this looks good:

Reviewed-by: Christoph Hellwig <hch@....de>