linux-kernel - Re: [PATCH] platform/x86: intel_scu_ipc: Increase virtual timeout from 3 to 5 seconds

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <74ea2a54-384c-9741-b269-f58ca15ea2f0@redhat.com>
Date:   Thu, 11 Feb 2021 16:50:36 +0100
From:   Hans de Goede <hdegoede@...hat.com>
To:     Casey Bowman <casey.g.bowman@...el.com>,
        mika.westerberg@...ux.intel.com
Cc:     dvhart@...radead.org, andy@...radead.org, azhar.shaikh@...el.com,
        lee.jones@...aro.org, platform-driver-x86@...r.kernel.org,
        linux-kernel@...r.kernel.org, heikki.krogerus@...ux.intel.com
Subject: Re: [PATCH] platform/x86: intel_scu_ipc: Increase virtual timeout
 from 3 to 5 seconds

Hi,

On 2/10/21 8:20 PM, Casey Bowman wrote:
> Increasing the virtual timeout time to account for scenarios
> that may require more time, like DisplayPort Multi-Stream Transport
> (DP MST), where the disconnect time can be extended longer than
> usual.
> 
> The recommended timeout range is 5-10 seconds, of which
> we will take the lower bound.
> 
> Signed-off-by: Casey Bowman <casey.g.bowman@...el.com>
> Acked-by: Heikki Krogerus <heikki.krogerus@...ux.intel.com>
> Acked-by: Mika Westerberg <mika.westerberg@...ux.intel.com>

Thank you for your patch, I've applied this patch to my review-hans 
branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans

Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.

Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.

Regards,

Hans

> ---
>  drivers/platform/x86/intel_scu_ipc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/platform/x86/intel_scu_ipc.c b/drivers/platform/x86/intel_scu_ipc.c
> index d9cf7f7602b0..9171a46a9e3f 100644
> --- a/drivers/platform/x86/intel_scu_ipc.c
> +++ b/drivers/platform/x86/intel_scu_ipc.c
> @@ -75,7 +75,7 @@ struct intel_scu_ipc_dev {
>  #define IPC_READ_BUFFER		0x90
>  
>  /* Timeout in jiffies */
> -#define IPC_TIMEOUT		(3 * HZ)
> +#define IPC_TIMEOUT		(5 * HZ)
>  
>  static struct intel_scu_ipc_dev *ipcdev; /* Only one for now */
>  static DEFINE_MUTEX(ipclock); /* lock used to prevent multiple call to SCU */
>