linux-kernel - Re: [PATCH 00/21] [Set 2] Rid W=1 warnings from Clock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 12 Feb 2021 14:05:45 -0800
From:   Stephen Boyd <sboyd@...nel.org>
To:     Lee Jones <lee.jones@...aro.org>
Cc:     linux-kernel@...r.kernel.org,
        Ahmad Fatoum <a.fatoum@...gutronix.de>,
        Andy Gross <agross@...nel.org>,
        Avi Fishman <avifishman70@...il.com>,
        Benjamin Fair <benjaminfair@...gle.com>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Boris BREZILLON <boris.brezillon@...e-electrons.com>,
        Chen-Yu Tsai <wens@...e.org>,
        Emilio López <emilio@...pez.com.ar>,
        Fabio Estevam <festevam@...il.com>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        Jan Kotas <jank@...ence.com>,
        Jernej Skrabec <jernej.skrabec@...l.net>,
        Jonathan Hunter <jonathanh@...dia.com>,
        linux-arm-kernel@...ts.infradead.org,
        linux-arm-msm@...r.kernel.org, linux-clk@...r.kernel.org,
        linux-omap@...r.kernel.org, linux-renesas-soc@...r.kernel.org,
        linux-tegra@...r.kernel.org, Loc Ho <lho@....com>,
        Maxime Ripard <mripard@...nel.org>,
        Michael Turquette <mturquette@...libre.com>,
        Michal Simek <michal.simek@...inx.com>,
        Nancy Yuen <yuenn@...gle.com>,
        Nuvoton Technologies <tali.perry@...oton.com>,
        NXP Linux Team <linux-imx@....com>, openbmc@...ts.ozlabs.org,
        Patrick Venture <venture@...gle.com>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Peter De Schrijver <pdeschrijver@...dia.com>,
        Philipp Zabel <p.zabel@...gutronix.de>,
        Prashant Gaikwad <pgaikwad@...dia.com>,
        Rajan Vaja <rajan.vaja@...inx.com>,
        Rajeev Kumar <rajeev-dlh.kumar@...com>,
        Richard Woodruff <r-woodruff2@...com>,
        Russell King <linux@...linux.org.uk>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Shawn Guo <shawnguo@...nel.org>,
        Shiraz Hashim <shiraz.linux.kernel@...il.com>,
        Sören Brinkmann <soren.brinkmann@...inx.com>,
        Tali Perry <tali.perry1@...il.com>,
        Tero Kristo <kristo@...nel.org>,
        Thierry Reding <thierry.reding@...il.com>,
        Tomer Maimon <tmaimon77@...il.com>,
        Viresh Kumar <vireshk@...nel.org>
Subject: Re: [PATCH 00/21] [Set 2] Rid W=1 warnings from Clock

Quoting Lee Jones (2021-02-12 13:26:30)
> On Fri, 12 Feb 2021, Lee Jones wrote:
> 
> > The alternative is to not worry about it and review the slow drip of
> > fixes that will occur as a result.  The issues I just fixed were built
> > up over years.  They won't get to that level again.
> > 
> > In my mind contributors should be compiling their submissions with W=1
> > enabled by default.  I'm fairly sure the auto-builders do this now.

That's good.

> > 
> > Once W=1 warnings are down to an acceptable level in the kernel as a
> > whole, we can provide some guidance in SubmittingPatches (or similar)
> > on how to enable them (hint: you add "W=1" on the compile line).
> > 
> > Enabling W=1 in the default build will only serve to annoy Linus IMHO.
> > If he wants them to be enabled by default, they wouldn't be W=1 in the
> > first place, they'd be W=0 which *is* the default build.
> 
> Just to add real quick - my advice is to enable them for yourself and
> send back any issues along with your normal review.  A W=1 issue is no
> different to a semantic or coding style one.
> 

I'd like to enable it for only files under drivers/clk/ but it doesn't
seem to work. I'm not asking to enable it at the toplevel Makefile. I'm
asking to enable it for drivers/clk/ so nobody has to think about it now
that you've done the hard work of getting the numbers in this directory
down to zero or close to zero.