linux-kernel - Re: [PATCH] vfio/type1: Use follow

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202102130645.bkehCefI-lkp@intel.com>
Date:   Sat, 13 Feb 2021 06:41:25 +0800
From:   kernel test robot <lkp@...el.com>
To:     Alex Williamson <alex.williamson@...hat.com>
Cc:     kbuild-all@...ts.01.org, cohuck@...hat.com, kvm@...r.kernel.org,
        linux-kernel@...r.kernel.org, pbonzini@...hat.com, jgg@...dia.com,
        peterx@...hat.com
Subject: Re: [PATCH] vfio/type1: Use follow_pte()

Hi Alex,

I love your patch! Yet something to improve:

[auto build test ERROR on vfio/next]
[also build test ERROR on v5.11-rc7 next-20210211]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Alex-Williamson/vfio-type1-Use-follow_pte/20210213-030541
base:   https://github.com/awilliam/linux-vfio.git next
config: i386-randconfig-a002-20210209 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce (this is a W=1 build):
        # https://github.com/0day-ci/linux/commit/d1aea3bcf226e5225e706acb7df2f4c68ea8858a
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Alex-Williamson/vfio-type1-Use-follow_pte/20210213-030541
        git checkout d1aea3bcf226e5225e706acb7df2f4c68ea8858a
        # save the attached .config to linux build tree
        make W=1 ARCH=i386 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   In file included from include/linux/mm.h:33,
                    from include/linux/scatterlist.h:8,
                    from include/linux/iommu.h:10,
                    from drivers/vfio/vfio_iommu_type1.c:27:
   drivers/vfio/vfio_iommu_type1.c: In function 'follow_fault_pfn':
>> include/linux/pgtable.h:81:24: error: implicit declaration of function 'kunmap_atomic'; did you mean 'iommu_map_atomic'? [-Werror=implicit-function-declaration]
      81 | #define pte_unmap(pte) kunmap_atomic((pte))
         |                        ^~~~~~~~~~~~~
   include/linux/mm.h:2231:2: note: in expansion of macro 'pte_unmap'
    2231 |  pte_unmap(pte);     \
         |  ^~~~~~~~~
   drivers/vfio/vfio_iommu_type1.c:494:2: note: in expansion of macro 'pte_unmap_unlock'
     494 |  pte_unmap_unlock(ptep, ptl);
         |  ^~~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors


vim +81 include/linux/pgtable.h

974b9b2c68f3d3 Mike Rapoport 2020-06-08  76  
974b9b2c68f3d3 Mike Rapoport 2020-06-08  77  #if defined(CONFIG_HIGHPTE)
974b9b2c68f3d3 Mike Rapoport 2020-06-08  78  #define pte_offset_map(dir, address)				\
974b9b2c68f3d3 Mike Rapoport 2020-06-08  79  	((pte_t *)kmap_atomic(pmd_page(*(dir))) +		\
974b9b2c68f3d3 Mike Rapoport 2020-06-08  80  	 pte_index((address)))
974b9b2c68f3d3 Mike Rapoport 2020-06-08 @81  #define pte_unmap(pte) kunmap_atomic((pte))
974b9b2c68f3d3 Mike Rapoport 2020-06-08  82  #else
974b9b2c68f3d3 Mike Rapoport 2020-06-08  83  #define pte_offset_map(dir, address)	pte_offset_kernel((dir), (address))
974b9b2c68f3d3 Mike Rapoport 2020-06-08  84  #define pte_unmap(pte) ((void)(pte))	/* NOP */
974b9b2c68f3d3 Mike Rapoport 2020-06-08  85  #endif
974b9b2c68f3d3 Mike Rapoport 2020-06-08  86  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (37938 bytes)