linux-kernel - Re: [PATCH 3/3] vfio/type1: Implement vma registration and restriction

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 13 Feb 2021 06:47:18 +0800
From:   kernel test robot <lkp@...el.com>
To:     Alex Williamson <alex.williamson@...hat.com>
Cc:     kbuild-all@...ts.01.org, clang-built-linux@...glegroups.com,
        cohuck@...hat.com, kvm@...r.kernel.org,
        linux-kernel@...r.kernel.org, jgg@...dia.com, peterx@...hat.com
Subject: Re: [PATCH 3/3] vfio/type1: Implement vma registration and
 restriction

Hi Alex,

I love your patch! Perhaps something to improve:

[auto build test WARNING on vfio/next]
[also build test WARNING on next-20210211]
[cannot apply to v5.11-rc7]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Alex-Williamson/vfio-Device-memory-DMA-mapping-improvements/20210213-033317
base:   https://github.com/awilliam/linux-vfio.git next
config: arm-randconfig-r032-20210212 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project c9439ca36342fb6013187d0a69aef92736951476)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install arm cross compiling tool for clang build
        # apt-get install binutils-arm-linux-gnueabi
        # https://github.com/0day-ci/linux/commit/f983107aef5b1386ae601ee8573da872f1484633
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Alex-Williamson/vfio-Device-memory-DMA-mapping-improvements/20210213-033317
        git checkout f983107aef5b1386ae601ee8573da872f1484633
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> drivers/vfio/vfio_iommu_type1.c:509:18: warning: no previous prototype for function 'pfnmap_find_dma' [-Wmissing-prototypes]
   struct vfio_dma *pfnmap_find_dma(struct pfnmap_obj *pfnmap)
                    ^
   drivers/vfio/vfio_iommu_type1.c:509:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   struct vfio_dma *pfnmap_find_dma(struct pfnmap_obj *pfnmap)
   ^
   static 
   1 warning generated.


vim +/pfnmap_find_dma +509 drivers/vfio/vfio_iommu_type1.c

   508	
 > 509	struct vfio_dma *pfnmap_find_dma(struct pfnmap_obj *pfnmap)
   510	{
   511		struct rb_node *n;
   512	
   513		for (n = rb_first(&pfnmap->iommu->dma_list); n; n = rb_next(n)) {
   514			struct vfio_dma *dma = rb_entry(n, struct vfio_dma, node);
   515	
   516			if (dma->pfnmap == pfnmap)
   517				return dma;
   518		}
   519	
   520		return NULL;
   521	}
   522	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (34203 bytes)