lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <130bc5f98c2fd501d32024d267ea73f1fb9d88b6.camel@perches.com> Date: Fri, 12 Feb 2021 14:51:26 -0800 From: Joe Perches <joe@...ches.com> To: "Eric W. Biederman" <ebiederm@...ssion.com> Cc: Andrew Morton <akpm@...ux-foundation.org>, Alexey Dobriyan <adobriyan@...il.com>, linux-fsdevel <linux-fsdevel@...r.kernel.org>, LKML <linux-kernel@...r.kernel.org> Subject: Re: [PATCH] proc: Convert S_<FOO> permission uses to octal On Fri, 2021-02-12 at 16:01 -0600, Eric W. Biederman wrote: > Joe Perches <joe@...ches.com> writes: > > > Convert S_<FOO> permissions to the more readable octal. > > > > Done using: > > $ ./scripts/checkpatch.pl -f --fix-inplace --types=SYMBOLIC_PERMS fs/proc/*.[ch] > > > > No difference in generated .o files allyesconfig x86-64 > > > > Link: > > https://lore.kernel.org/lkml/CA+55aFw5v23T-zvDZp-MmD_EYxF8WbafwwB59934FV7g21uMGQ@mail.gmail.com/ > > > I will be frank. I don't know what 0644 means. I can never remember > which bit is read, write or execute. So I like symbolic constants. > > I don't see a compelling reason to change the existing code. Did you read Linus' message in the Link: above? It was a reply to what Ingo Molnar suggested here: https://lore.kernel.org/lkml/20160803081140.GA7833@gmail.com/
Powered by blists - more mailing lists