linux-kernel - Re: [PATCH net-next v2] misc: Add Renesas Synchronization Management Unit (SMU) support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YCYw5xXe16fSj6eI@kroah.com>
Date:   Fri, 12 Feb 2021 08:40:23 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     min.li.xe@...esas.com
Cc:     derek.kiernan@...inx.com, dragan.cvetic@...inx.com, arnd@...db.de,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v2] misc: Add Renesas Synchronization Management
 Unit (SMU) support

On Thu, Feb 11, 2021 at 08:16:15PM -0500, min.li.xe@...esas.com wrote:
> From: Min Li <min.li.xe@...esas.com>
> 
> This driver supports 1588 related functions of ClockMatrix(TM)
> and 82P33xxx families of timing and synchronization devices.
> 
> The driver is developed to be only used by Renesas PTP Clock
> Manager for Linux (pcm4l) software. It supports 1588/PTP
> releated functionalities that specific to Renesas devices
> but are not supported by general PHC framework. So pcm4l
> will use both the existing PHC driver and this module to
> complete 1588/PTP support. The supported functons are:
> 
> -set combomode
> -get dpll's state
> -get dpll's ffo
> 
> This driver must work with Renesas MFD driver to access SMU
> through I2C/SPI.
> 
> Changes since v1:
> -Provide more background for purpose of the change.
> -Provide compat_ioctl support
> -Fix ioctl cmd definition

This "changes" list goes below the --- line.

And you seem to have ignored my review, especially about documenting the
sysfs files here, please do that as I can not accept this patch as-is.

greg k-h