linux-kernel - Re: [PATCH 1/2] staging: greybus: Fixed alignment issue in hid.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210212092130.cxo6tuess6msf4kb@vireshk-i7>
Date:   Fri, 12 Feb 2021 14:51:30 +0530
From:   Viresh Kumar <viresh.kumar@...aro.org>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     Pritthijit Nath <pritthijit.nath@...oud.com>,
        devel@...verdev.osuosl.org, elder@...nel.org, vireshk@...nel.org,
        johan@...nel.org, linux-kernel@...r.kernel.org,
        greybus-dev@...ts.linaro.org
Subject: Re: [PATCH 1/2] staging: greybus: Fixed alignment issue in hid.c

On 12-02-21, 10:17, Greg KH wrote:
> On Fri, Feb 12, 2021 at 02:39:26PM +0530, Viresh Kumar wrote:
> > On 12-02-21, 13:48, Pritthijit Nath wrote:
> > > This change fixes a checkpatch CHECK style issue for "Alignment should match
> > > open parenthesis".
> > > 
> > > Signed-off-by: Pritthijit Nath <pritthijit.nath@...oud.com>
> > > ---
> > >  drivers/staging/greybus/hid.c | 4 ++--
> > >  1 file changed, 2 insertions(+), 2 deletions(-)
> > > 
> > > diff --git a/drivers/staging/greybus/hid.c b/drivers/staging/greybus/hid.c
> > > index ed706f39e87a..a56c3fb5d35a 100644
> > > --- a/drivers/staging/greybus/hid.c
> > > +++ b/drivers/staging/greybus/hid.c
> > > @@ -221,8 +221,8 @@ static void gb_hid_init_reports(struct gb_hid *ghid)
> > >  }
> > > 
> > >  static int __gb_hid_get_raw_report(struct hid_device *hid,
> > > -		unsigned char report_number, __u8 *buf, size_t count,
> > > -		unsigned char report_type)
> > > +				   unsigned char report_number, __u8 *buf, size_t count,
> > > +				   unsigned char report_type)
> > >  {
> > >  	struct gb_hid *ghid = hid->driver_data;
> > >  	int ret;
> > 
> > I can't even count the number of attempts we have seen in previous
> > years to make checkpatch --strict happy for greybus.
> > 
> > I say we make this change once and for all across greybus, so we don't
> > have to review or NAK someone afterwards.
> > 
> > Should I send a patch for this ?
> 
> Sure, but note that over time, checkpatch adds new things so there will
> always be something to change in here, until we move it out of the
> drivers/staging/ area :)

Right, though I wasn't worried about other checkpatch warning but
specially the "alignment - parenthesis" one. Everyone (specially
newbies) want to fix that everywhere :)

-- 
viresh