linux-kernel - Re: This reply comments on the patch to fixes the missing a blank line warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0192c01f-4f90-7a58-ce12-b753495fec8c@redhat.com>
Date:   Fri, 12 Feb 2021 11:22:33 +0100
From:   David Hildenbrand <david@...hat.com>
To:     Adithya Chandrakasan <adithya.chandrakasan@...il.com>,
        akpm@...ux-foundation.org
Cc:     linux-mm@...ck.org, linux-kernel@...r.kernel.org,
        skhan@...uxfoundation.org
Subject: Re: This reply comments on the patch to fixes the missing a blank
 line warning

On 12.02.21 11:14, David Hildenbrand wrote:
> On 11.02.21 19:20, Adithya Chandrakasan wrote:
>> On 2/11/21 2:36 AM, David Hildenbrand wrote:
>>> ^
>>>
>>> Please create proper patch subjects. Nobody has a glue what you are doing when looking at the subject.
>>>
>>> "mm/util: fix ??? warning"
>>>
>>> Which raises the question, what is ???
>>>
>>> Compiler? static code checker? ... ?
>>>
> 
> 
> 
>>>
>>> Thanks
>>>
>>> On 11.02.21 08:29, Adithya Chandrakasan wrote:
>>>> FILE: mm/util.c:930: WARNING: Missing a blank line after declarations
>>>>
>>>> Signed-off-by: Adithya Chandrakasan <adithya.chandrakasan@...il.com>
>>>> ---
>>>>      mm/util.c | 1 +
>>>>      1 file changed, 1 insertion(+)
>>>>
>>>> diff --git a/mm/util.c b/mm/util.c
>>>> index 8c9b7d1e7c49..60286876636d 100644
>>>> --- a/mm/util.c
>>>> +++ b/mm/util.c
>>>> @@ -927,6 +927,7 @@ int get_cmdline(struct task_struct *task, char *buffer, int buflen)
>>>>          unsigned int len;
>>>>          struct mm_struct *mm = get_task_mm(task);
>>>>          unsigned long arg_start, arg_end, env_start, env_end;
>>>> +
>>>>          if (!mm)
>>>>              goto out;
>>>>          if (!mm->arg_end)
>>>>
>>>
>>>
>> Hi David,
>>
>> Thanks for feedback. I have fixed the issues in the patch thread with
>> change in subject and also log message.
> 
> Hi,
> 
> Please always send patches via proper mails and versioned.
> 
> E.g.,
> 
> rm *.patch
> git format-patch -1 -v2
> git send-email --to ... *.patch
> 
> 
> The introducing patch is from 2014. So I wonder how you even get a
> checkpatch warning?
> 
> a90902531a06a ("proc read mm's {arg,env}_{start,end} with mmap semaphore
> taken.")

Sorry wrong pointer, it's from 2014

a90902531a06 ("mm: Create utility function for accessing a tasks 
commandline value")


-- 
Thanks,

David / dhildenb