linux-kernel - Re: [PATCH] spi: Skip zero-length transfers in spi_transfer_one

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210212123118.GB6057@sirena.org.uk>
Date:   Fri, 12 Feb 2021 12:31:18 +0000
From:   Mark Brown <broonie@...nel.org>
To:     Nicolas Saenz Julienne <nsaenzjulienne@...e.de>
Cc:     Robin Murphy <robin.murphy@....com>,
        Phil Elwell <phil@...pberrypi.com>, linux-spi@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] spi: Skip zero-length transfers in
 spi_transfer_one_message()

On Thu, Feb 11, 2021 at 07:08:20PM +0100, Nicolas Saenz Julienne wrote:

> -		if (xfer->tx_buf || xfer->rx_buf) {
> +		if ((xfer->tx_buf || xfer->rx_buf) && xfer->len) {

I think the issue here is more that some users were passing in buffers
with zero length transfers, the above check was already intended to
catch this case but was working on the assumption that if there was
nothing to transfer then no buffer would be provided.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)