linux-kernel - Re: drivers/leds/flash/leds-rt8515.c:216: undefined reference to `v4l2_flash

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210212133254.GA31749@duo.ucw.cz>
Date:   Fri, 12 Feb 2021 14:32:54 +0100
From:   Pavel Machek <pavel@....cz>
To:     Linus Walleij <linus.walleij@...aro.org>
Cc:     kernel test robot <lkp@...el.com>, Arnd Bergmann <arnd@...db.de>,
        kbuild-all@...ts.01.org,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Sakari Ailus <sakari.ailus@...ux.intel.com>
Subject: Re: drivers/leds/flash/leds-rt8515.c:216: undefined reference to
 `v4l2_flash_release'

On Fri 2021-02-12 13:38:58, Linus Walleij wrote:
> I need Arnds help with this...
> 
> On Fri, Feb 12, 2021 at 12:05 AM kernel test robot <lkp@...el.com> wrote:
> 
> >    ld: drivers/leds/flash/leds-rt8515.o: in function `rt8515_v4l2_flash_release':
> > >> drivers/leds/flash/leds-rt8515.c:216: undefined reference to `v4l2_flash_release'
> >    ld: drivers/leds/flash/leds-rt8515.o: in function `rt8515_probe':
> >    drivers/leds/flash/leds-rt8515.c:354: undefined reference to `v4l2_flash_init'
> 
> So the problem is that this is compiled in, so CONFIG_LEDS_RT8515=y
> (it is tristate so can also be a module)
> but it depends on symbols from a module:
> CONFIG_V4L2_FLASH_LED_CLASS=m.
> 
> In the code I try to only support the V4L2 interface when using V4L2:
> #if IS_ENABLED(CONFIG_V4L2_FLASH_LED_CLASS)
> (... V4L2 code...)
> 
> Is there a way to define in Kconfig that if and only if you enable
> this other module it has to follow the y or m that we use for this
> driver?
> 
> Or do I simply have to bite the bullet, make it bool and
> depend on CONFIG_V4L2_FLASH_LED_CLASS || !CONFIG_V4L2_FLASH_LED_CLASS
> ?

Arnd already submitted patch for this one... depends is right, no need
to make it bool, I believe.

Best regards,
								Pavel
-- 
http://www.livejournal.com/~pavelmachek

Download attachment "signature.asc" of type "application/pgp-signature" (196 bytes)