linux-kernel - Re: [PATCH] [v13] wireless: Initial driver submission for pureLiFi STA devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 12 Feb 2021 23:06:46 +0800
From:   kernel test robot <lkp@...el.com>
To:     Srinivasan Raju <srini.raju@...elifi.com>
Cc:     kbuild-all@...ts.01.org, mostafa.afgani@...elifi.com,
        Srinivasan Raju <srini.raju@...elifi.com>,
        Kalle Valo <kvalo@...eaurora.org>,
        Jakub Kicinski <kuba@...nel.org>,
        open list <linux-kernel@...r.kernel.org>,
        "open list:NETWORKING DRIVERS (WIRELESS)" 
        <linux-wireless@...r.kernel.org>
Subject: Re: [PATCH] [v13] wireless: Initial driver submission for pureLiFi
 STA devices

Hi Srinivasan,

I love your patch! Perhaps something to improve:

[auto build test WARNING on wireless-drivers-next/master]
[also build test WARNING on wireless-drivers/master net-next/master net/master linus/master sparc-next/master v5.11-rc7 next-20210211]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Srinivasan-Raju/wireless-Initial-driver-submission-for-pureLiFi-STA-devices/20210212-195451
base:   https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git master
config: arm64-allyesconfig (attached as .config)
compiler: aarch64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/5d8fb5ce1f136940c10fd16bc96856d2f6ad2741
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Srinivasan-Raju/wireless-Initial-driver-submission-for-pureLiFi-STA-devices/20210212-195451
        git checkout 5d8fb5ce1f136940c10fd16bc96856d2f6ad2741
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   drivers/net/wireless/purelifi/plfxlc/mac.c: In function 'purelifi_mac_tx_status':
>> drivers/net/wireless/purelifi/plfxlc/mac.c:219:19: warning: variable 'retry' set but not used [-Wunused-but-set-variable]
     219 |  int success = 1, retry = 1;
         |                   ^~~~~


vim +/retry +219 drivers/net/wireless/purelifi/plfxlc/mac.c

   198	
   199	/**
   200	 * purelifi_mac_tx_status - reports tx status of a packet if required
   201	 * @hw - a &struct ieee80211_hw pointer
   202	 * @skb - a sk-buffer
   203	 * @flags: extra flags to set in the TX status info
   204	 * @ackssi: ACK signal strength
   205	 * @success - True for successful transmission of the frame
   206	 *
   207	 * This information calls ieee80211_tx_status_irqsafe() if required by the
   208	 * control information. It copies the control information into the status
   209	 * information.
   210	 *
   211	 * If no status information has been requested, the skb is freed.
   212	 */
   213	static void purelifi_mac_tx_status(struct ieee80211_hw *hw,
   214					   struct sk_buff *skb,
   215					   int ackssi,
   216					   struct tx_status *tx_status)
   217	{
   218		struct ieee80211_tx_info *info = IEEE80211_SKB_CB(skb);
 > 219		int success = 1, retry = 1;
   220	
   221		ieee80211_tx_info_clear_status(info);
   222	
   223		if (tx_status) {
   224			success = !tx_status->failure;
   225			retry = tx_status->retry + success;
   226		}
   227	
   228		if (success)
   229			info->flags |= IEEE80211_TX_STAT_ACK;
   230		else
   231			info->flags &= ~IEEE80211_TX_STAT_ACK;
   232	
   233		info->status.ack_signal = 50;
   234		ieee80211_tx_status_irqsafe(hw, skb);
   235	}
   236	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (76491 bytes)